added vault create, modify and distribute methods - #23
Merged
Conversation
Owner
|
thx! Next time try to adhere to https://www.conventionalcommits.org/en/v1.0.0/ to format commit messages, as stated on CONTRIBUTING.md. Plus, would it be too much to ask for testing? You can take a look a the ones in order creation/canccelation at go-hyperliquid/exchange_orders_test.go Line 163 in 9fffbfb |
Pull Request Test Coverage Report for Build 17000425267Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Added additional vault management methods, see ts sdk for ref
Type of Change