Skip to content

added vault create, modify and distribute methods - #23

Merged
sonirico merged 1 commit into
sonirico:masterfrom
vyomshm:feat/add-vault-methods
Aug 15, 2025
Merged

added vault create, modify and distribute methods#23
sonirico merged 1 commit into
sonirico:masterfrom
vyomshm:feat/add-vault-methods

Conversation

@vyomshm

@vyomshm vyomshm commented Aug 15, 2025

Copy link
Copy Markdown
Contributor

Pull Request

Description

Added additional vault management methods, see ts sdk for ref

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement

@sonirico

sonirico commented Aug 15, 2025

Copy link
Copy Markdown
Owner

thx! Next time try to adhere to https://www.conventionalcommits.org/en/v1.0.0/ to format commit messages, as stated on CONTRIBUTING.md.

Plus, would it be too much to ask for testing? You can take a look a the ones in order creation/canccelation at

func TestOrders(t *testing.T) {

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 17000425267

Details

  • 0 of 89 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 20.957%

Changes Missing Coverage Covered Lines Changed/Added Lines %
exchange_others.go 0 89 0.0%
Totals Coverage Status
Change from base Build 16974691234: -0.7%
Covered Lines: 600
Relevant Lines: 2863

💛 - Coveralls

@sonirico
sonirico merged commit 9ad011b into sonirico:master Aug 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants