Conversation
…o#344) With Soloist, changing the volume in the Spotify app did nothing to the speaker. Soloist emits a dedicated `volume_changed` event for the device the app targets, but onEvent never read it — only the librespot backend wired `updateVolume`. Handle `volume_changed` by forwarding event.volume to the zone via the controller, mirroring the librespot path. Only the targeted `volume_changed` is applied, not the account-level `volume` that rides along on every `playback_state` (Connect broadcasts that to every device, so applying it would pull idle rooms to the playing room's level). Fixes sonn-audio#344. Verified against the deterministic repro (Web-API volume 45/75/30 on a Soloist zone): before, the sendspin client stayed at its default; after, it logs `Server set player volume: 45%/75%/30%`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #344 — root cause found and fix verified against a deterministic repro.
Diagnosis
Confirmed a bug (not by design). With Soloist,
soloistPlaybackService.onEvent()never reads the volume:updateVolumeis wired only in the librespot backend (spotifyInputService.ts), and the Soloist pathforwards timing/queue/metadata but not volume.
Instrumenting
onEventand changing the app volume via the Web API shows Soloist does send it, as adedicated event targeted at the active device:
(The
volumethat also appears on everyplayback_stateis the account-level value Connect broadcasts toevery device — zones 4/5/6/8/9 all reported
volume=100at once — so that one must not be applied, or idlerooms follow the playing room. Only the targeted
volume_changedis safe.)Fix
Handle
volume_changedinonEventand forward to the zone, mirroring the librespot path:Verification
Web-API volume
45 → 75 → 30on a Soloist zone (patched into the running container'sdist):Server set player volume: 45% / 75% / 30%— the app volume now reaches thespeaker.