Repository navigation
Commit 7ead34c
fix(skills/copilot-review-loop): stop review waits that never exit (#98)
* fix(skills/copilot-review-loop): say how a subagent waits for the review
Step 3 said only that the harness re-invokes the session when the wait
script exits. A subagent that did not trust the wake made up its own
wait, often a background `until ! pgrep -f "await-copilot-review.sh"`
loop. That loop matches its own command line and never ends, so
finished subagents stayed alive for hours.
Step 3 now says that the one background shell is the whole wait, to
read its output file on each wake, and to run the script in the
foreground with a bounded timeout when no wake comes. It forbids a
second watcher, and it says that no background shell may still run
when the agent reports back.
Towards #97
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(skills/fanning-out-with-worktrees): leave the review wait to the loop skill
The orchestrator wrote its own wait instructions into the dispatch
prompt of each review-loop subagent ("poll yourself with a backgrounded
command"). That advice led subagents to the self-matching pgrep wait.
The ripening step now says that the prompt names the review-loop skill
and adds no wait instructions of its own.
Towards #97
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(skills/copilot-review-loop): judge the wait by its exit code, not its output
An empty output file does not show that the wait script still runs.
The script can exit early without output, for example when
`gh repo view` fails under `set -e`. The agent then ends its turn
again and waits for a wake that already came. Step 3 now reads the
task's exit code first, and on an exit other than 0 or 124 it reports
the failure and does not wait again.
Towards #97
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>1 parent 94002b6 commit 7ead34c
2 files changed
Lines changed: 14 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
111 | 121 | | |
112 | 122 | | |
113 | 123 | | |
| |||
181 | 191 | | |
182 | 192 | | |
183 | 193 | | |
| 194 | + | |
| 195 | + | |
184 | 196 | | |
185 | 197 | | |
186 | 198 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
106 | | - | |
| 106 | + | |
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
| |||
0 commit comments