fix: Invalidate the request URL even when the response has no headers (#153)

A response cut short by a timeout or a connection reset can reach the delete path with nil headers, and reading Location out of it raised NoMethodError inside on_complete. Fall back to an empty header set so the request URL is still invalidated.

Fixes #142

Author: georgeguimaraes

lib/faraday/http_cache.rb

@@ -314,9 +314,11 @@ def authorization_bearing?
     end
 
     def delete(request, response)
-      headers = %w[Location Content-Location]
-      headers.each do |header|
-        url = response.headers[header]
+      # A response cut short by a timeout or a reset can arrive without
+      # headers; there is still an entry to invalidate for the request URL.
+      headers = response.headers || {}
+      %w[Location Content-Location].each do |header|
+        url = headers[header]
         @strategy.delete(url) if url
       end
 

spec/http_cache_spec.rb

@@ -96,6 +96,33 @@
       client.get('broken')
     end
 
+    it 'still expires the request URL when the response has no headers' do
+      store = Faraday::HttpCache::MemoryStore.new
+      cached = Faraday.new(url: ENV['FARADAY_SERVER']) do |stack|
+        stack.use Faraday::HttpCache, store: store
+        stack.adapter ENV['FARADAY_ADAPTER'].to_sym
+      end
+      # Mimics an adapter that gives up mid-response: the env is completed
+      # with no status worth the name and no response headers at all.
+      headerless_adapter = Class.new(Faraday::Adapter) do
+        def call(env)
+          super
+          env.status = 0
+          env.response_headers = nil
+          env.response.finish(env)
+        end
+      end
+      broken = Faraday.new(url: ENV['FARADAY_SERVER']) do |stack|
+        stack.use Faraday::HttpCache, store: store
+        stack.adapter headerless_adapter
+      end
+
+      cached.get('get')
+      broken.post('get')
+
+      expect(cached.get('get').body).to eq('2')
+    end
+
     it 'expires entries for the "Location" header' do
       client.get('get')
       client.post('delete-with-location')