Skip to content

Update train.py - #157

Open
danielvalencia95 wants to merge 1 commit into
sovit-123:mainfrom
danielvalencia95:patch-2
Open

Update train.py#157
danielvalencia95 wants to merge 1 commit into
sovit-123:mainfrom
danielvalencia95:patch-2

Conversation

@danielvalencia95

Copy link
Copy Markdown

Ensure the use of patience for early stopping

Ensure the use of patience for early stopping
@sovit-123

Copy link
Copy Markdown
Owner

Hello @danielvalencia95 I think the command line argument already employs a default value of 10 for early stopping. I think the change you made might not be necessary. Please let me know if I am missing something.

@danielvalencia95

Copy link
Copy Markdown
Author

Hello @sovit-123 the default value works, but with a different values the early stopping don´t work.

Also, i made another PR for the eval.py

@sovit-123

Copy link
Copy Markdown
Owner

That's a bit odd. I will surely test it out and if necessary will merge your code.
Thanks.

@danielvalencia95

Copy link
Copy Markdown
Author

Hello @sovit-123

Ok, please also review my PR about eval.py

@sovit-123

Copy link
Copy Markdown
Owner

Will do that, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants