fix(server): cache handler responses that also set cookies

i18n writes ubean_locale on every response; rejecting Set-Cookie made cachedEventHandler a no-op.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: honghuangdc

examples/ubean-test/test/cache.test.ts

@@ -9,7 +9,7 @@ import {
   resolveRouteCacheRules
 } from 'ubean';
 import type { UbeanContext } from 'ubean';
-import { getJson } from './helper';
+import { getJson, postJson } from './helper';
 
 describe('Cache system', () => {
   describe('createMemoryStore() - memory storage', () => {
@@ -186,12 +186,13 @@ describe('Cache system', () => {
 
   describe('HTTP integration - /api/cache-test (cachedEventHandler)', () => {
     it('returns cached result on second call', async () => {
+      await postJson('/api/cache-test');
       const res1 = await getJson('/api/cache-test');
       const res2 = await getJson('/api/cache-test');
       expect(res1.status).toBe(200);
       expect(res2.status).toBe(200);
-      // Both should return the same timestamp (cached)
       expect((res1.data as { timestamp: number }).timestamp).toBe((res2.data as { timestamp: number }).timestamp);
+      expect(res2.headers.get('x-cache')).toBe('HIT');
     });
   });
 });

packages/server/src/cache.ts

@@ -260,9 +260,10 @@ function isCacheableRequest(c: Context): boolean {
 
 function isCacheableResponse(res: Response): boolean {
   if (res.status !== 200) return false;
-  if (res.headers.get('set-cookie')) return false;
   const cc = res.headers.get('cache-control');
   if (cc && (cc.includes('private') || cc.includes('no-store'))) return false;
+  // Set-Cookie (e.g. i18n `ubean_locale`) is stripped in serializeResponse.
+  // Rejecting it here made `cachedEventHandler` a no-op in apps with i18n.
   return true;
 }
 
@@ -333,11 +334,11 @@ export function cachedEventHandler<T extends (c: Context) => Response | Promise<
   handler: T,
   options: CacheRule = { ttl: 60 }
 ): T {
-  const store = useCacheStore();
   const ttl = options.ttl;
   const keyBase = options.name;
 
   return (async (c: Context) => {
+    const store = useCacheStore();
     const key = keyBase || buildCacheKey(c);
 
     if (ttl > 0 && isCacheableRequest(c)) {

packages/server/test/cache-handler.test.ts

@@ -0,0 +1,34 @@
+import { afterEach, describe, expect, it } from 'vitest';
+import { Hono } from 'hono';
+import { cachedEventHandler, clearCacheStore, createMemoryStore, useCacheStore } from '../src/cache';
+
+afterEach(() => {
+  clearCacheStore();
+});
+
+describe('cachedEventHandler', () => {
+  it('caches JSON even when the live response sets a cookie', async () => {
+    useCacheStore(createMemoryStore());
+    let n = 0;
+    const app = new Hono();
+    app.get(
+      '/x',
+      cachedEventHandler(
+        c => {
+          n += 1;
+          c.header('Set-Cookie', 'ubean_locale=en; Path=/; SameSite=Lax');
+          return c.json({ n });
+        },
+        { ttl: 60, name: 'cookie-ok' }
+      )
+    );
+
+    const miss = await app.request('/x');
+    const hit = await app.request('/x');
+    expect(miss.status).toBe(200);
+    expect((await miss.json()) as { n: number }).toEqual({ n: 1 });
+    expect((await hit.json()) as { n: number }).toEqual({ n: 1 });
+    expect(hit.headers.get('x-cache')).toBe('HIT');
+    expect(n).toBe(1);
+  });
+});