Skip to content

Generalise Mode to be any eigenmode, not just frequency eigenmode #5

Description

@sp94

The Mode object returned by solve(solver, k, polarisation) could be generalised

Currently it is assumed to be a frequency eigenmode

Mode(k0::Vector, frequency::Number, data::Vector...)

We should rename frequency to eigval, data to eigvec, and add a label string

Mode(k0::Vector, eigval::Number, eigvec::Vector, label::String, ...)

solve(solver, k, polarisation) could return array of Mode(k0, eigval, eigvec, "Frequency")

wilson_eigen() could return array of Mode(k0, eigval, eigvec, "Wilson loop eigenvalue")

The label field could be used by eg plot_band_diagram to automatically label the y-axis

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions