Allow implicit conversion between EntityPrototype ProtoIds and EntProtoIds - #7014
Open
SnappingOpossum wants to merge 6 commits into
Open
SnappingOpossum wants to merge 6 commits into
SnappingOpossum wants to merge 6 commits into
Conversation
I shoulda tried building earlier but honestly I'm surprised that was used at all. Might be better to leave it as a breaking change and fix it in content, this seems like a bad way to handle this itself.
I really oughta do this more thouroughly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They mean the same thing but aren't always able to be used in the same places. Too and from in the
EntProtoIdstruct since regularProtoIdis generic, didn't add conversions forEntProtoId<T>since regularEntProtoIdcan't be converted into it, only out.Had to mess with ProtoMan a little to get rid of a breaking change, and I'm not too happy with it. If this is bad with that in mind I don't mind this being closed, as it's mostly a minor convenience.