Fix client predicteddel running on detaching entities - #7015
Open
metalgearsloth wants to merge 2 commits into
Open
metalgearsloth wants to merge 2 commits into
metalgearsloth wants to merge 2 commits into
Conversation
The issue is that the client will restore the entity in a weird state so we just need to block those situations entirely.
DrSmugleaf
reviewed
Aug 22, 2026
DrSmugleaf
left a comment
DrSmugleaf
left a comment
Contributor
There was a problem hiding this comment.
Would this mess up deleting as it comes back into pvs range? Otherwise unless entity lookup is fixable I guess this works
Contributor
Author
Should only affect predicteddel as deletions get run at the very end of applyentitystates separately. |
DrSmugleaf
approved these changes
Aug 23, 2026
DrSmugleaf
left a comment
DrSmugleaf
left a comment
Contributor
There was a problem hiding this comment.
Should be fine, even if you mispredict a delete the entity is getting detached anyways
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is that the client will restore the entity in a weird state so we just need to block those situations entirely. Once it's detached we should just ignore it entirely.
This should defensively guard against space-wizards/space-station-14#45410 from the engine side.