Conversation
3 tasks
Contributor
|
Doesn't this muddy which file comes from which source? |
Contributor
|
presumably youd only do that if every file listed uses all sources, similar case to listing multiple files for a directory permalink. i imagine youd only list filea actually taken from there |
Member
Author
|
Yeah in the case of my linked PR (and the one in the example), both sounds listed in the |
Contributor
|
This is a breaking change from the specification so at the very least that should also be updated in conjunction with this PR. |
3 tasks
Member
Author
|
Made a PR for the spec update space-wizards/docs#673 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working on an audio file and in it I used two sounds from different sources. I want to attribute them both, but the current schema only accepts a single source. With my limited understanding of the schema validation (and help from Whatstone) I believe this will work to make my
source:list validate without any breaking changes.