Conversation
i. e.: B.C still matches for A.B.C, but not for A.BB.C
CREAsTIVE
marked this pull request as draft
September 7, 2026 22:40
…rename it for better fit)
Author
|
Requires merge of space-wizards/space-station-14#45913 first (to pass tests). All tests pass on my machine and game works perfectly fine with that fix |
CREAsTIVE
marked this pull request as ready for review
September 8, 2026 00:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
ReflectionManager.TryLooseGetTypematched part of name, i. e. typeShuttleConsoleBoundUserInterfacemay be matched asTradeShuttleConsoleBoundUserInterfaceeffectively replacing existing one without any warnings or something.Initially i matched withI just use already written method for enums.Split('.').TakeLast(...).SequenceEqual(...), but that allocates too much so i just went with checking for existence of.or+(for nested types, i. e.A.B.C+D)Related issues: #5648