Conversation
4 tasks
Mackamuir
marked this pull request as draft
September 18, 2026 04:59
Mackamuir
marked this pull request as ready for review
September 18, 2026 12:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been beating my ass for the last 2 weeks.
Issue
If a partial changes a protos
parent:, it loses everything it should have inherited from further up the chain. It only keepswhat its new parent declares directly.
Example
What should happen:
WrenchgetsItemfromBasetool, and keeps the sprite path fromBaseItem.What currently happens:
WrenchgetsItembutSpriteonly getslayersand no sprite path, sinceBaseItemget's skipped, leading to the error:Layer has no RSI to load states from. Cannot use 'state' property.tldr:
MultiRootInheritanceGraph.Addset the protos new parent list, but never told the old parents their child was gone, causing a stale edge that resolves the child too early, against a parent that hasn't been built yet.Fix
Addnow detaches the node from its old parents before wiring up the new ones, and assigns _parents[id] once rather than inside the loop.