Fix PipeOutput() not closing files correctly - #303
Open
JiyuSoftware wants to merge 1 commit into
Open
JiyuSoftware wants to merge 1 commit into
JiyuSoftware wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PipeOutput()never closes the log files properly. This means the tail end of every log in the unwritten buffer is never written.This probably fixes issues like: space-wizards/space-station-14#39186
What this also fixes is that old output that might still be present in the buffer from an old session which will get written to a new session's log.
Another interesting finding is that before commit
0e50acd("Don't do text conversion when logging client") both streams were wrapped usingawait using. This PR essentially restores the old proper closing behaviour from before0e50acd, but keeps the fix for non-ASCII characters by deliberately not reintroducingAutoFlush=true.