Examinable stamina damage - #46044
Open
peaceful-joules wants to merge 7 commits into
Open
peaceful-joules wants to merge 7 commits into
peaceful-joules wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Now stamina damage is shown with other damage types in the verb.
Why / Balance
There were a lot of experimental changes to the disablers and other stun weapons. You (just because you are reading this right now) and I both know exactly how much damage disablers and enforcers deal, because both of us are able to use github. But this doesn't apply to all players, some may play on wizden for the first time, some may after a really long break, and every stamina damage change is unexpected for them. It is really good to see damage and other stats without opening a wiki/github. Also fixes empty examine messages on disablers and other non-harm weapons with stun.
Technical details
Welp, actually, help wanted. I don't fully understand how to implement this, because stamina damage is a damage type... that actually isn't a damage type. It has its own components, and it can't be transformed into the damagespec, so, I don't know if my implementation is okay, therefore, ideas are welcome.
Test plan
Media
Requirements
Changelog
🆑