Skip to content

Commit 4b5701b

Browse files
committed
build: restore Automatic-Module-Name in MANIFEST.MF
Fixes #9 - a regression from v5.1.2 where Java Module Support was broken due to the removal of the automatic module name. Also, to prevent overwriting the parent's configuration, 'combine.children="append"' is added to <manifestEntries>. Reported-by: Colm Divilly <@cdivilly>
1 parent 5038e4b commit 4b5701b

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

pom.xml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,8 @@
9898
<developerId>spannm</developerId>
9999
<githubBaseUrl>https://github.com/${developerId}/</githubBaseUrl>
100100

101+
<module.name>${project.groupId}.${project.artifactId}</module.name>
102+
101103
<dep.poi.version>5.5.1</dep.poi.version>
102104

103105
<dep.slf4j.version>2.0.18</dep.slf4j.version>
@@ -361,7 +363,7 @@
361363
<addDefaultSpecificationEntries>false</addDefaultSpecificationEntries>
362364
<addBuildEnvironmentEntries>true</addBuildEnvironmentEntries>
363365
</manifest>
364-
<manifestEntries>
366+
<manifestEntries combine.children="append">
365367
<Build-Time>${maven.build.timestamp}</Build-Time>
366368
<Project-Java-Version>${project.build.targetJdk}</Project-Java-Version>
367369

@@ -382,6 +384,8 @@
382384

383385
<Organization-Name>${project.organization.name}</Organization-Name>
384386
<Organization-Url>${project.organization.url}</Organization-Url>
387+
388+
<Automatic-Module-Name>${module.name}</Automatic-Module-Name>
385389
</manifestEntries>
386390
</archive>
387391
</configuration>

0 commit comments

Comments
 (0)