Feedback - #1

Open

github-classroom[bot] wants to merge 271 commits into

This pull request is big! We're only showing the most recent 250 commits

Commits on Mar 19, 2024

fix: change root/vertex type in AbstractTree

ns-58
authored and
vicitori
committed
5ae2be1
fix: change AVLVertex constructor
ns-58
committed
c1a6f0e
fix: add replaceIfExist param to AVLTree put()
ns-58
committed
235c14b
add AVLTree rotateLeft()
ns-58
committed
7f6baf2
feat: implement funs put and remove a little
sevenbunu
committed
ed0ff25
chore: sort the code files into thematic folders
sevenbunu
committed
223b75c
style: add line breaks and implement changes in AbstractBinarySearchTree
sevenbunu
committed
9848b48
chore: delete extra files
sevenbunu
committed
f123121
Merge branch 'develop' into CI
sevenbunu
committed
85c119c

Commits on Mar 20, 2024

Merge pull request #6 from spbu-coding-2023/CI
ns-58
authored
2eb3f3f
Merge branch 'develop' into AVL
ns-58
committed
6685dbe
fix: add return to AVLTree rotateLeft()
ns-58
committed
69ddb6e
feat: add AVLTree rotateRight()
ns-58
committed
6ef3e06
chore: merge develop and RB branches
sevenbunu
committed
a1377da
feat: add init block in TreeIterator class

vicitori
authored and
sevenbunu
committed
aca7007
feat: add TreeIterator's method hasNext()

vicitori
authored and
sevenbunu
committed
746a01a
feat: add TreeIterator's method next()

vicitori
authored and
sevenbunu
committed
4a0d666
fix: change vertex type in primary constructor from InterfaceBSTVertex<K, V, N>? to N?

vicitori
authored and
sevenbunu
committed
0951f00
feat: implement AbstractBinarySearchTree method iterator() and import TreeIterator class

vicitori
authored and
sevenbunu
committed
0175351
style: rename folder nodes to vertexes
sevenbunu
committed
49c3797
chore: merge CI and RB branches
sevenbunu
committed
7d908ce
feat: delete class pair
sevenbunu
committed
6c08841
Merge branch 'develop' into CI
sevenbunu
authored
c606f5d
feat: implement left and right rotates
sevenbunu
committed
035a038

Commits on Mar 21, 2024

Commits on Mar 22, 2024

fix: change AVLTree rotate funcs constructors
ns-58
committed
308d49f
feat: add AVLTree balance()
ns-58
committed
03f2dd2
feat: add AVLTree putRec()
ns-58
committed
a78b5f9
fix : add size enlargers in AVLTree putRec()
ns-58
committed
e128fa9
fix: remove types after 'as' in some conctructors
ns-58
committed
30c7c8a
feat: add partially written SimpleBinarySearchTree private method removeRec()
vicitori
committed
04add6a
feat: implement protected AbstractBinarySearchTree's method getMinKeyNodeRec()

vicitori
authored and
ns-58
committed
bd52736
feat: implement protected AbstractBinarySearchTree's method getMaxKeyNodeRec()

vicitori
authored and
ns-58
committed
e20ac1d
feat: add the replaceIfExists parameter to the signature of putAll() method and to the constructor

vicitori
authored and
ns-58
committed
1a3e45a
fix: add replaceIfExists parameter to the constructors of AVLSearchTree, RBSearchTree and SimpleBinarySearchTree classes

vicitori
authored and
ns-58
committed
636052e
feat: implement AVLTree put()
ns-58
committed
be40aab
feat: implement comparator fun
sevenbunu
committed
c7efc86
fix: edit compareKeys() constructor; some style improvements
ns-58
committed
40f9847

Commits on Mar 23, 2024

feat: implement comparator fun

sevenbunu
authored and
vicitori
committed
15af7dd
fix: edit compareKeys() constructor; some style improvements

ns-58
authored and
vicitori
committed
dc2ce55
fix: make protected AbstractTree compareKeys()
ns-58
authored
b50e2c7
Merge branch 'develop' into comparator
vicitori
authored
7b0683a
Merge pull request #13 from spbu-coding-2023/comparator
vicitori
authored
bf804bb
feat: write SimpleBinarySearchTree private method removeRec()
vicitori
committed
132dda4
feat: write SimpleBinarySearchTree method remove()
vicitori
committed
396d19c
feat: implement fun remove
sevenbunu
committed
4ab8d39
fix: return types after 'as'
ns-58
committed
fb3b786
fix: some style improvements
ns-58
committed
c3b64ad
fix: edit 'when' expressions in AbstractTree compareKeys()

ns-58
authored and
sevenbunu
committed
a2965f1
fix : some style improvements in AbstractTree compareKeys()

ns-58
authored and
sevenbunu
committed
113f206
Merge branch 'develop' into RB
sevenbunu
committed
4e72429
Merge branch 'develop' into RB
sevenbunu
committed
0a134f6
fix: add 'when root changed' case in AVLTree put()
ns-58
committed
19fdac4
fix: fix typo in putRecShort() call
ns-58
committed
6056cf9
fix: change some return values in AVLTree putRec()
ns-58
committed
22320a2
Merge branch 'AbstractTree-simplest-methods' into develop
ns-58
authored
e0bc8ad
fix: rewrite AbstractTree getRec() using compareKeys()
ns-58
committed
ff4b9f6
fix: swap vertex.key and key

sevenbunu
authored and
ns-58
committed
7819d6a
fix: remove unnecessary 'else's in AVLTree putRec()
ns-58
committed
e5fcd15

Commits on Mar 24, 2024

Commits on Mar 25, 2024

fix: change init order in AbstractTree constructor

ns-58
authored and
sevenbunu
committed
287b1a5

Commits on Mar 28, 2024

Merge pull request #22 from spbu-coding-2023/AVL
sevenbunu
authored
9e70218

Commits on Mar 29, 2024

chore: add explanatory comments
sevenbunu
committed
29e2a48

Commits on Mar 30, 2024

Commits on Mar 31, 2024

test: add several tests for the RBTree
sevenbunu
committed
de28b8c
test: full test coverage of put
sevenbunu
committed
036b015
feat: make AVLTree open, add AVLTreeForTest class
ns-58
committed
2af5274
Merge branch 'tests' into SimpleBinarySearchTree
vicitori
committed
fc8180c
fix: add root value change on removing in SimpleBinarySearchTree private method removeRec()
vicitori
committed
6262d58
feat: do class SimpleBinarySearchTree open fot tests
vicitori
committed
db1c984
feat: add new class TestSimpleBST for tests which inherits SimpleBinarySearchTree class and write method getTreeRoot()
vicitori
committed
d63c6d7
feat: write tests for SimpleBinarySearchTree class
vicitori
committed
197b418
feat: add test 'remove non-existing value' in SimpleBSTree class
vicitori
committed
16b7e56
feat : add putTest functions
ns-58
committed
c578f30
fix (AVLTree) : remove wrongs in work with RemovaleStage values
ns-58
committed
bdc6b58
feat: add README.md
vicitori
committed
6896c58
fix: deleted logo.png and Project Structure in Table of Contents at README.md
vicitori
committed
5cd9a37

Commits on Apr 1, 2024

test: add tests for remove, coverage is about 93%
sevenbunu
committed
33bbb7a
dosc: add dosc to InterfaceBSTVertex
vicitori
committed
dd45d95
dosc: add dosc to AVLVertex
vicitori
committed
7644903
dosc: add dosc to RBVertex
vicitori
committed
2ba91c0
dosc: add dosc to SimpleBSTVertex
vicitori
committed
92585b3
dosc: add dosc to AbstractBinarySearchTree
vicitori
committed
1bdc476
dosc: add dosc to SimpleBinarySearchTree
vicitori
committed
47ef5ce
dosc: add dosc to AVLSearchTree
vicitori
committed
91a13ef
dosc: add dosc to RBSearchTree
vicitori
committed
fe0576a
dosc: add dosc to TreeIterator
vicitori
committed
8014d7a
feat: add project structure and contributing in README.md
vicitori
committed
b300cf4
refactor: change text size and rename title 'Project Structure' to 'Library Features' in README.md
vicitori
committed
c0c8792
Merge pull request #30 from spbu-coding-2023/SimpleBinarySearchTree
ns-58
authored
e6ed8ea
fix: do class TreeIterator open and do stack protected
vicitori
committed
1ed29b3
feat: write class TestIterator for test
vicitori
committed
376bec6
fix (AVLTree, putRec()) : add removalStage D
ns-58
committed
5808e12
feat : add removeTest
ns-58
committed
4ef6c91
refactor: auto codsetyle changes
ns-58
committed
503e2ee
test: add 100% test coverage
sevenbunu
committed
bef4b1c
chore: delete ci.yml
sevenbunu
authored
d847a75
feat: add ci.yml
sevenbunu
authored
5b90851
test: add test coverage for AbstractTree methods
sevenbunu
committed
329ca92
feat: write tests for TreeIterator class
vicitori
committed
2cbb182
fix: remove 'get root' test
vicitori
committed
4fe22c6
fix: add default comparator value null in constructor
vicitori
committed
d0360e3
fix: add default comparator value null in constructor
vicitori
committed
d9ebfdb
ci: add new cases for checks
sevenbunu
committed
4bb84e0
refactor: add setup before each test, coverage 100%
vicitori
committed
bb05fab
refactor: update README.md
vicitori
authored
ebc1699
ci: implement linter
sevenbunu
committed
3ffbbfa
style: changes according to linter
sevenbunu
committed
f70e024
style: final changes according to linter
sevenbunu
committed
8974583
chore: delete extra code
sevenbunu
committed
5dd7e53
Merge branch 'develop' into CI
sevenbunu
authored
bdbfa33
merge linter into CI
sevenbunu
committed
5fe695d
style: change according to linter
sevenbunu
committed
21b81bc
style: add spaces after //
sevenbunu
committed
c9e813e
refactor: update code insertions in README.md
vicitori
authored
bf7c378
Merge branch 'develop' into RB
sevenbunu
authored
96ec67e
Merge pull request #39 from spbu-coding-2023/CI
ns-58
authored
55219da
Merge branch 'develop' into RB
sevenbunu
authored
23a98f8
style: final changes according to the linter
sevenbunu
authored
221b31e
docs: add warning about attempting to perform put, remove, or get operations on a non-empty binary search tree with a key that is incomparable with the keys in the tree
vicitori
committed
b0ca253
fix: resolve merge conflict
vicitori
committed
c46904a
fix: remove the wrong file
vicitori
committed
0f08794
docs: add documentation to SimpleBinarySearchTree
vicitori
committed
cbbe090

Commits on Apr 2, 2024

Merge pull request #40 from spbu-coding-2023/RB
ns-58
authored
dd7b3e3
Merge branch 'develop' into iteratorTest
ns-58
authored
f4fd0c4
Merge pull request #35 from spbu-coding-2023/iteratorTest
ns-58
authored
d1c24ff
Merge branch 'develop' into AVLTest
sevenbunu
authored
5bae6a9
style: changes according to linter
sevenbunu
committed
9472247
style: more changes according to linter
sevenbunu
committed
5b6bab2
style: delete extra imports, add cosmetic changes
sevenbunu
committed
aae2ece
style: final changes according to linter
sevenbunu
committed
4d4420b
style: imports in lexicographic order
sevenbunu
committed
c51a4e4
docs: add param vertex to docs of AVLSearchTree method putRec()
vicitori
committed
93c8412
fix: resolve conflicts to merge in develop
vicitori
committed
4fc37ba
Merge pull request #32 from spbu-coding-2023/AVLTest
sevenbunu
authored
79189db
feat : add AbstractTreeTest

ns-58
authored and
sevenbunu
committed
676469c
merge develop into SimpleBinarySearchTree
sevenbunu
committed
2965e18
Merge pull request #34 from spbu-coding-2023/SimpleBinarySearchTree
sevenbunu
authored
b5e3931
chore: sort tests into folders
sevenbunu
committed
f9049bb
Merge branch 'develop' into docs
vicitori
committed
ec45c15
Merge pull request #44 from spbu-coding-2023/docs
sevenbunu
authored
5fd07aa
style: changes according to linter

sevenbunu
authored and
ns-58
committed
1e12169
style: final changes according to linter

sevenbunu
authored and
ns-58
committed
1fef4f5
Merge pull request #45 from spbu-coding-2023/develop
ns-58
authored
1813fa2

Commits on Apr 3, 2024

test: add one more test

sevenbunu
authored and
vicitori
committed
5abc7ba
feat: update tests for SimpleBST
vicitori
committed
65bbc16
fix: move check for null root to removeRec() method and remove default initialization of replaceIfExists parameter
vicitori
committed
d63e853
style: changes according to linter
vicitori
committed
28e9ebb
fix: correct AVLTree rotate functions' documentation

ns-58
authored and
vicitori
committed
46945b3

Commits on Apr 6, 2024

feat(AbstractTree) : add isNotEmpty() method

ns-58
authored and
vicitori
committed
0d85520
feat: add test coverage
sevenbunu
committed
025a838
fix: delete extra code
sevenbunu
committed
92080c1
fix: change name of reports
sevenbunu
committed
166b79a
fix: add permissions
sevenbunu
committed
e4274a9
feat: add emoji on tests
sevenbunu
committed
2705e13
feat: add test report
sevenbunu
committed
d140a3f
fix: change path to csv
sevenbunu
committed
15caf8a
feat: add emoji)
sevenbunu
committed
b56cc5d
feat: add title of report
sevenbunu
committed
57b758b
feat: add skip case
sevenbunu
committed
5636249
test: comment some tests to see changes in report
sevenbunu
committed
f41871e
test: comment some rbtree code to see changes in jacoco report
sevenbunu
committed
2f03751
feat: finally add tests reports
sevenbunu
committed
ccc41af
chore: change emoji
sevenbunu
committed
9a346bd

Commits on Apr 7, 2024

fix and refactor AVL tree

ns-58
authored and
vicitori
committed
01507c8
refactor(AVLTest) : sort tests into classes, fix typos

ns-58
authored and
vicitori
committed
fbd42ce
feat : add AbstractTreeTest

ns-58
authored and
vicitori
committed
8e2c218
feat(AbstractTreeTest) : add tests for isNotEmpty() method, fix typos

ns-58
authored and
vicitori
committed
02bd44f
fix comparator
ns-58
authored
0395609
feat: add test coverage

sevenbunu
authored and
vicitori
committed
8bfcb74
fix: delete extra code

sevenbunu
authored and
vicitori
committed
947e068
fix: change name of reports

sevenbunu
authored and
vicitori
committed
34e90e1
fix: add permissions

sevenbunu
authored and
vicitori
committed
e2183d4
feat: add emoji on tests

sevenbunu
authored and
vicitori
committed
99e16c9
feat: add test report

sevenbunu
authored and
vicitori
committed
f9a3bea
fix: change path to csv

sevenbunu
authored and
vicitori
committed
537f81e
feat: add emoji)

sevenbunu
authored and
vicitori
committed
c2a4782
feat: add title of report

sevenbunu
authored and
vicitori
committed
859e3eb
feat: add skip case

sevenbunu
authored and
vicitori
committed
0509db7
test: comment some tests to see changes in report

sevenbunu
authored and
vicitori
committed
fd56462
test: comment some rbtree code to see changes in jacoco report

sevenbunu
authored and
vicitori
committed
13f5d74
feat: finally add tests reports

sevenbunu
authored and
vicitori
committed
514e8fe
chore: change emoji

sevenbunu
authored and
vicitori
committed
3696fc0
feat: add Dokka plugin and dependence in build.gradle.kts
vicitori
committed
4a8d87b
feat: add custom Gradle tasks for javadoc.jar building
vicitori
committed
af0c6ef
fix(AVL, RB): correct typos
vicitori
committed
1ef17db
refactor(test): rename class for tests to SimpleBSTForTest
vicitori
committed
523bf10
refactor: rename packages and imports
vicitori
committed
5a19f8a
docs(AbstractTree): supplement documentation
vicitori
committed
383ec97
docs(vertexes): remove obvious parameter descriptions
vicitori
committed
f1231a8
docs(AVL): change the class description and add types of function parameters
vicitori
committed
b1b848e
docs(RB, BST, AbstractTree): add function parameter types
vicitori
committed
d329d48
docs(Iterator): refactor descriptions
vicitori
committed
2a57ee2
ci: add right path to xml
sevenbunu
committed
4f0bcb2
Merge branch 'fixes-after-1st-review' into CI-fixes
sevenbunu
authored
eca11c4

Commits on Apr 8, 2024

feat: add class enum for color

sevenbunu
authored and
ns-58
committed
aa35352
fix: reuse code in balanceAfterPut, delete extra code

sevenbunu
authored and
ns-58
committed
fb9776c
fix: reuse code in BalanceAfterRemove, delete extra code

sevenbunu
authored and
ns-58
committed
da11d49
docs: replace property isRed with a color

sevenbunu
authored and
ns-58
committed
97e0fcd
Merge pull request #58 from spbu-coding-2023/CI-fixes
ns-58
authored
5327767
docs: add description of replaceSubtreeSRootByLargestInItsLeftSubtree() in AVL

sevenbunu
authored and
ns-58
committed
6626c08
Merge branch 'fixes-after-1st-review' into docs
ns-58
authored
13c4495
Merge pull request #59 from spbu-coding-2023/docs
ns-58
authored
595d124
style: changes according to linter
sevenbunu
committed
ba602df
style: final changes according to linter
sevenbunu
committed
ac74e9d
Merge pull request #60 from spbu-coding-2023/fixes-after-1st-review
sevenbunu
authored
d557110