chore: use literal shells for the Windows installer CI matrix [skip changelog] (#136)

The Windows installer smoke-test job set `shell` from a matrix
expression, which GitHub Actions rejects as an invalid workflow file, so
the Test workflow no longer parses on main. The job now has one
conditional step per matrix entry with a literal shell, so both
`powershell` and `pwsh` still run as separate matrix jobs.

<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Fixes the Windows installer smoke-test job so the Test workflow parses
on main. GitHub Actions rejects `shell` values from matrix expressions,
so the job now uses one conditional step per matrix entry with a literal
shell, keeping `powershell` and `pwsh` as separate matrix jobs. The test
script also loads the Archive module before replacing `Expand-Archive`
and captures installer output as it streams, initializing it before the
test body, so test failures print the output.

<sup>Written for commit 3dc630b.
Summary will update on new commits.</sup>

<a
href="https://cubic.dev/pr/speakeasy-api/openapi-generation/pull/136?utm_source=github"
target="_blank" rel="noopener noreferrer"
data-no-image-dialog="true"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source
media="(prefers-color-scheme: light)"
srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img
alt="View guided diff"
src="https://www.cubic.dev/buttons/review-in-cubic-light.svg"></picture></a>
<a
href="https://www.cubic.dev/action/auto-fix/pr/speakeasy-api/openapi-generation/136?returnTo=https%3A%2F%2Fgithub.com%2Fspeakeasy-api%2Fopenapi-generation%2Fpull%2F136&source=description"
target="_blank" rel="noopener noreferrer"
data-no-image-dialog="true"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://www.cubic.dev/buttons/turn-on-auto-fix-dark.svg"><source
media="(prefers-color-scheme: light)"
srcset="https://www.cubic.dev/buttons/turn-on-auto-fix-light.svg"><img
alt="Turn on auto-fix"
src="https://www.cubic.dev/buttons/turn-on-auto-fix-light.svg"></picture></a>

<!-- End of auto-generated description by cubic. -->

Author: AshGodfrey

.github/workflows/test.yml

@@ -192,8 +192,13 @@ jobs:
       - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
         with:
           persist-credentials: false
-      - name: Test generated Windows installer
-        shell: ${{ matrix.shell }}
+      - name: Test generated Windows installer (powershell)
+        if: matrix.shell == 'powershell'
+        shell: powershell
+        run: ./scripts/test-windows-installer.ps1
+      - name: Test generated Windows installer (pwsh)
+        if: matrix.shell == 'pwsh'
+        shell: pwsh
         run: ./scripts/test-windows-installer.ps1
   test-cli:
     if: always() && needs.detect-targets.outputs.run-cli == 'true'

scripts/test-windows-installer.ps1

@@ -54,7 +54,12 @@ function Invoke-Installer {
     }
     $global:InstallerTestArchive = $Sandbox.Archive
     $global:InstallerTestDownloads = @()
-    & $InstallerPath *>&1 | ForEach-Object { "$_" }
+    $global:InstallerTestOutput = @()
+    & $InstallerPath *>&1 | ForEach-Object {
+        $line = "$_"
+        $global:InstallerTestOutput += $line
+        $line
+    }
 }
 
 function global:Invoke-RestMethod {
@@ -67,6 +72,8 @@ function global:Invoke-WebRequest {
     Copy-Item -LiteralPath $global:InstallerTestArchive -Destination $OutFile
 }
 
+Import-Module Microsoft.PowerShell.Archive
+
 $global:InstallerTestOpenHandle = $null
 function global:Expand-Archive {
     param([string]$Path, [string]$DestinationPath, [switch]$Force)
@@ -77,6 +84,7 @@ function global:Expand-Archive {
     }
 }
 
+$global:InstallerTestOutput = @()
 try {
     Write-Host '--- install succeeds and cleans up'
     $global:InstallerTestHoldExtractedBinary = $false
@@ -106,6 +114,11 @@ try {
         Write-Host '--- skipping held-file cleanup case: open files can be deleted on this platform'
     }
 }
+catch {
+    Write-Host '--- installer output'
+    $global:InstallerTestOutput | ForEach-Object { Write-Host "  $_" }
+    throw
+}
 finally {
     if ($global:InstallerTestOpenHandle) {
         $global:InstallerTestOpenHandle.Dispose()