Skip to content

chore(php): update setup-php to the latest 8.3 patch in CI [skip changelog] - #127

Merged
AshGodfrey merged 2 commits into
mainfrom
ash/php-ci-setup-php-update
Oct 21, 2026
Merged

AshGodfrey merged 2 commits into
mainfrom
ash/php-ci-setup-php-update

Conversation

@AshGodfrey

@AshGodfrey AshGodfrey commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Why

The PHP test workflow runs setup-php with php-version: "8.3". When the requested minor version is preinstalled on the runner image, setup-php switches to that build instead of installing the newest patch, so CI kept running whatever 8.3.x the runner image was built with until the image was rebuilt. PHP security releases should reach CI on the next run, not on the next image refresh.

What changed

  • .github/workflows/test-php.yml: set update: true on the setup-php step so it installs the latest 8.3 patch release on every run.

No generator or template changes; no generated output changes.

Testing

  • git diff --check is clean.
  • Verified against the setup-php README: preinstalled versions are not updated to their latest patch unless update is set.
  • Not run locally: the workflow itself. The PHP test jobs on this PR exercise the change.

Public-safety check

  • This change contains no credentials, customer documents, private repository URLs, private filesystem paths, or unredacted private logs.
  • Title, body, comments, and commit messages name no customers or customer-derived identifiers, private paths or trackers, or workflow provenance, and are understandable without private context (.claude/skills/public-repo-communication/SKILL.md).
  • Generated fixtures and review SDK changes are public-safe.
  • I reviewed git diff --check.

Summary by cubic

Ensures CI installs the latest PHP 8.3 patch release every run by setting update: true on the setup-php step, so security fixes reach CI immediately instead of waiting for a runner image rebuild. The flag is passed as an environment variable since setup-php reads update from the environment rather than its inputs.

Written for commit 16b339f. Summary will update on new commits.

View guided diff Turn on auto-fix

…gelog]

setup-php reuses the PHP build preinstalled on the runner image when it
satisfies the requested minor version, so CI stayed on whatever 8.3.x the
image was built with. Setting update: true installs the latest 8.3 patch
release on every run.
@AshGodfrey
AshGodfrey requested a review from a team as a code owner October 21, 2026 12:02
@AshGodfrey
AshGodfrey requested a review from mfbx9da4 October 21, 2026 12:02

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would auto-approve. Sets update: true on the setup-php step in the PHP CI workflow so each run installs the latest PHP 8.3 patch, ensuring security fixes are tested promptly instead of waiting for a runner image rebuild. This is a bounded one-line change to development-only CI configuration.

View guided diff | Turn on auto-fix | Re-trigger cubic

setup-php reads update from the environment, not from its inputs.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would auto-approve. Moves the setup-php update: true flag into an env var in the PHP CI workflow so each run installs the latest PHP 8.3 patch, since setup-php reads update from the environment. This is a bounded, development-only CI configuration change with no runtime or product impact.

View guided diff | Turn on auto-fix | Re-trigger cubic

@bflad bflad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird way to do it but confirmed in their docs 👍

@AshGodfrey
AshGodfrey added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit b55b0c0 Oct 21, 2026
155 checks passed
@AshGodfrey
AshGodfrey deleted the ash/php-ci-setup-php-update branch October 21, 2026 17:22
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants