Repository navigation
chore: use literal shells for the Windows installer CI matrix [skip changelog] - #136
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Fixes an invalid GitHub Actions workflow by replacing a matrix-expanded shell: expression with literal shells in conditional steps, restoring workflow parsing while preserving both powershell and pwsh matrix coverage. Bounded CI-only fix with no external behavior change.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Shadow auto-approve: would not auto-approve because issues were found.
View guided diff | Turn on auto-fix | Re-trigger cubic
AshGodfrey
changed the title
|
Going to bypass rules on this one because I hastily merged #135. This is all testing, so low risk to merge without approval. |
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Shadow auto-approve: would not auto-approve because issues were found.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Fixes GitHub Actions workflow parsing while preserving PowerShell coverage, and prints installer output on smoke-test failures. CI-only change with no runtime impact.
View guided diff | Turn on auto-fix | Re-trigger cubic
The Windows installer smoke-test job set
shellfrom a matrix expression, which GitHub Actions rejects as an invalid workflow file, so the Test workflow no longer parses on main. The job now has one conditional step per matrix entry with a literal shell, so bothpowershellandpwshstill run as separate matrix jobs.Summary by cubic
Fixes the Windows installer smoke-test job so the Test workflow parses on main. GitHub Actions rejects
shellvalues from matrix expressions, so the job now uses one conditional step per matrix entry with a literal shell, keepingpowershellandpwshas separate matrix jobs. The test script also loads the Archive module before replacingExpand-Archiveand captures installer output as it streams, initializing it before the test body, so test failures print the output.Written for commit 3dc630b. Summary will update on new commits.