Allow custom claims on WIT-SVIDs - #410
Open
MarcosDY wants to merge 2 commits into
Open
Conversation
Signed-off-by: Marcos Yacob <marcosyacob@gmail.com>
MarcosDY
requested review from
amartinezfayo,
azdagron and
evan2645
as code owners
August 4, 2026 15:41
Comment on lines
+7
to
+8
| // GetWITSVID returns the default WIT-SVID from the source. It is used by | ||
| // code that presents a credential and therefore has no ID to look up. |
Member
There was a problem hiding this comment.
I'm not sure I understand the second sentence, there's no credential to present either way. The first sentence seems good enough so you could leave it at that.
Collaborator
Author
There was a problem hiding this comment.
yeap, it is why i added it because i need into another pr and in caes I dont know the spiffeID lets me remvoe that.
Signed-off-by: Marcos Yacob <marcosyacob@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.