perf: use indexed LoadPolicy in UpsertPolicy instead of full scan - #294
Merged
Conversation
…scan UpsertPolicy called LoadAllPolicies and looped to find one policy by name, loading and decrypting every policy on every upsert. Switch to the existing LoadPolicy(ctx, name) indexed lookup (name is the primary key), treating ErrEntityNotFound as the create case. Behavior is unchanged; cost drops from O(n) with full decryption to a single indexed read. Also fix stale "by its ID" doc comments and id parameter names on the LoadPolicy and DeletePolicy backend interface methods (policies are keyed by name). Context housekeeping in .context/TASKS.md: mark the lookup task done; skip the obsolete maxShardID task (the constant no longer exists); and retarget the DB-operation-timeout task at the SDK's env.DatabaseOperationTimeoutVal(), where that accessor now lives. Spec: TBD Signed-off-by: Volkan Özçelik <volkan.ozcelik@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpsertPolicy called LoadAllPolicies and looped to find one policy by name, loading and decrypting every policy on every upsert. Switch to the existing LoadPolicy(ctx, name) indexed lookup (name is the primary key), treating ErrEntityNotFound as the create case. Behavior is unchanged; cost drops from O(n) with full decryption to a single indexed read.
Also fix stale "by its ID" doc comments and id parameter names on the LoadPolicy and DeletePolicy backend interface methods (policies are keyed by name).
Context housekeeping in .context/TASKS.md: mark the lookup task done; skip the obsolete maxShardID task (the constant no longer exists); and retarget the DB-operation-timeout task at the SDK's env.DatabaseOperationTimeoutVal(), where that accessor now lives.
Spec: TBD