Repository navigation
fix: normalize business knowledge vector IDs - #569
Merged
zxuexingzhijie merged 2 commits intoJul 28, 2026
Merged
zxuexingzhijie merged 2 commits into
zxuexingzhijie merged 2 commits into
Conversation
March-77
marked this pull request as ready for review
July 22, 2026 02:02
…knowledge-filter # Conflicts: # data-agent-management/src/main/java/com/alibaba/cloud/ai/dataagent/service/business/BusinessKnowledgeServiceImpl.java
Contributor
Author
|
已合并最新 main 并解决冲突。新写入的业务术语使用字符串 ID,删除和过滤仍兼容旧的数值 ID。相关测试 72 个通过,格式和 Checkstyle 也通过。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
businessTermIdvector metadata as a stringSimpleVectorStorefilter implementationRoot cause
SimpleVectorStoreevaluates metadata filters through SpEL. Numeric values in anINexpression are parsed asInteger, while business knowledge IDs were stored asLong, so equality always failed and no business terms were recalled.Validation
./mvnw -pl data-agent-management -Dtest=DynamicFilterServiceTest,DocumentConverterUtilTest,BusinessKnowledgeServiceImplTest test(58 tests)./mvnw -pl data-agent-management spotless:check checkstyle:checkgit diff --checkFixes #460