build: add Spring Boot Buildpacks support - #554
Conversation
| THC_PATH: / | ||
| healthcheck: | ||
| test: ["CMD", "curl", "-I", "http://config-server:8888"] | ||
| test: ["CMD", "/workspace/health-check"] |
There was a problem hiding this comment.
question Is this change compatible with the existing Dockerfile?
I don't think they have this paketo health checker
There was a problem hiding this comment.
Good catch. You're right — changing the shared Compose health check to /workspace/health-check assumes that the existing Dockerfile-built images also contain the Paketo health checker. I'll verify the existing workflow and update the implementation so that the buildDocker workflow remains compatible.
There was a problem hiding this comment.
We could align both versions with the same URL.
There was a problem hiding this comment.
Thanks. Do you mean aligning the health check target between the existing Dockerfile-built images and the Buildpack-built images by using the same health endpoint path/URL, while keeping the Buildpack-specific internal port configuration where required?
Signed-off-by: 98001yash <yashchauhan.gaya@gmail.com>
|
2 participants
Description
Fixes #248
Adds Spring Boot Cloud Native Buildpacks support while preserving the existing Dockerfile-based
buildDockerworkflow. Also replaces thecurl-based Compose health checks with the Paketo health-checker used by Buildpacks images.Type of change
Changes
buildImageMaven profile using Spring Boot'sbuild-image-no-forkgoal.curlhealth checks indocker-compose.ymlwith/workspace/health-check.THC_PORTandTHC_PATHconfiguration for the config and discovery servers../mvnw clean install -PbuildImageworkflow in the README.buildDockerprofile unchanged.Validation
./mvnw validate -PbuildImage— passeddocker compose config— passedgit diff --check— passedChecklist
mainbranch of spring-petclinic/spring-petclinic-microservices, not my own fork./mvnw test) — not run as part of this changeThe implementation follows issue #248 and keeps the existing Dockerfile-based workflow available alongside Buildpacks.