Use Parser-bound DeserializationContext for parsing type hints in TypeResolver - #3404
Closed
mp911de wants to merge 4 commits into
Closed
Use Parser-bound DeserializationContext for parsing type hints in TypeResolver#3404mp911de wants to merge 4 commits into
DeserializationContext for parsing type hints in TypeResolver#3404mp911de wants to merge 4 commits into
Conversation
…TypeResolver`. We now use the deserialization context bound to the JSON parser instead of using the unbound and generic Mapper DeserializationContext that is actually only visible for testing.
Add Jackson 2 test, move off _deserializationContext where possible.
Contributor
|
Reviewed, looks good to me. I have two small nitpicks. |
mhalbritter
changed the title
DeserializationContext for parsing type hints in TypeResolver`DeserializationContext for parsing type hints in TypeResolver
Contributor
|
Merged and backported. Thanks @mp911de ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now use the deserialization context bound to the JSON parser instead of using the unbound and generic Mapper
DeserializationContextthat is actually only visible for testing.Also, use
StdTypeResolverBuilderif possible to defer_deserializationContext()access.Closes #3396