Fix argument validation in RedisData.setTimeToLive(Long, TimeUnit) - #3406
Closed
JuHyun419 wants to merge 1 commit into
Closed
Fix argument validation in RedisData.setTimeToLive(Long, TimeUnit)#3406JuHyun419 wants to merge 1 commit into
JuHyun419 wants to merge 1 commit into
Conversation
The second Assert.notNull call was checking timeToLive again instead of timeUnit, so passing a null TimeUnit fell through to an unguarded NullPointerException from TimeUnit.SECONDS.convert(...) instead of the intended IllegalArgumentException. Added RedisDataUnitTests covering the null TimeUnit case, the existing null TTL case, and the regular seconds conversion path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NCNaLYkirUWaphVdUZPvEa Signed-off-by: juhyun <zzang9ha@naver.com>
spring-projects-issues
added
the
status: waiting-for-triage
mhalbritter
added
type: bug
mhalbritter
pushed a commit
that referenced
this pull request
Jul 30, 2026
Closes #3406 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: juhyun <zzang9ha@naver.com>
mhalbritter
pushed a commit
that referenced
this pull request
Jul 30, 2026
Closes #3406 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: juhyun <zzang9ha@naver.com>
Contributor
|
Merged, polished and backported. Thanks @JuHyun419 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RedisData.setTimeToLive(Long, TimeUnit)had a copy/paste bug: the secondAssert.notNull(...)call re-checkedtimeToLiveinstead of validatingtimeUnit.nullTimeUnitskipped the intended fail-fastIllegalArgumentExceptionand instead threw an unguardedNullPointerExceptionfromTimeUnit.SECONDS.convert(...).timeUnitas the message already stated.RedisDataUnitTestscovering: nullTimeUnit(new behavior), nulltimeToLive(existing behavior), and the regular seconds-conversion path (regression guard).Test plan
RedisDataUnitTestspass (./mvnw test -Dtest=RedisDataUnitTests)./mvnw compile/test-compilesucceed