Repository navigation
GH-1969 - Apply configured headers in JMS and AMQP event externalization - #1970
Open
Adrastopoulos wants to merge 1 commit into
Open
Adrastopoulos wants to merge 1 commit into
Adrastopoulos wants to merge 1 commit into
Conversation
…nt externalization. The JMS transport never applied the headers configured via EventExternalizationConfiguration.headers(…). It now maps them onto the JMS message using SimpleJmsHeaderMapper, as JmsMessagingTemplate does. Since 2.1, the AMQP transport merges the configured headers with the publisher confirm correlation but sends only the latter. It now sends the merged headers. Signed-off-by: Gabriel Hall <gabriel.hall@cox.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1969.
The JMS transport now maps
getHeadersFor(…)onto the JMS message withSimpleJmsHeaderMapper, the mapperJmsMessagingTemplateuses. The AMQP transport now sends the merged headers instead of only the additional ones, so both the configured headers and the publisher confirm correlation reachconvertAndSend(…).events.adocnow lists JMS among the brokers that support headers.The JMS and AMQP integration tests each get an
addsHeadersIfConfigured()test like Kafka's. Both fail without the fix.