Skip to content

Commit ae4fb2d

Browse files
CIclaude
andcommitted
docs(discovery): spec errata from the final review - write_and_poll_sleep is 10 on the GE types; charge_rate_percent means power control
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1 parent 8a8f630 commit ae4fb2d

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎docs/superpowers/specs/2026-09-24-discovery-inverter-record-vocabulary-design.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -217,13 +217,13 @@ The definition is built from four sources:
217217
| `charge_time_format` | `charge_start_time`'s `format` |
218218
| `clock_time_format` | `inverter_time`'s `format` |
219219
| `soc_units` | which state-of-charge setting is bound: `soc_percent` -> `%`, `soc_kw` -> `kWh` |
220-
| `output_charge_control` | `charge_rate`'s `unit`: W -> `power`, A -> `current`; no entity -> `none` |
220+
| `output_charge_control` | `charge_rate`'s `unit`: W -> `power`, A -> `current`; no `charge_rate` but a bound `charge_rate_percent` (GE Cloud's percentage-rate models) -> `power`; neither -> `none` |
221221
| `current_dp` | the decimal places of `charge_rate`'s `step`, when its unit is A |
222222
| `time_button_press` | whether a `schedule_write_button` entity is present |
223223
| `num_load_entities` | 1 plus the number of consecutive `load_power_1`, `load_power_2`, ... entities bound (`inverter.py:1523` adds them into the load reading) |
224224

225-
4. **The component** - `write_and_poll_sleep`, a constant on the component class. It is 2 for every
226-
component-driven type today.
225+
4. **The component** - `write_and_poll_sleep`, a constant on the component class (`ComponentBase.WRITE_AND_POLL_SLEEP`).
226+
It is 2 for the cloud types and 10 for the GivEnergy types (GE, GEC, GEE), which GivTCP and GE Cloud override.
227227

228228
`has_mqtt_api` (Sofar's MQTT path) defaults to `False`, its value for every component-driven type.
229229

0 commit comments

Comments
 (0)