docs(octopus): explain why a Smart Control change is always sent, and count four car entities (#5341 review)

The switch handler sends SUSPEND/UNSUSPEND even when the switch already
shows that state: the cached device state can be up to a poll old, so
skipping the call could drop a real change made in the Octopus app just
before. The build_discovery docstring now lists four car entities, and a
leftover smart_control_confirmed line is removed from the test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: chalfontchubby

apps/predbat/octopus.py

@@ -1230,6 +1230,9 @@ async def async_set_intelligent_smart_control(self, device_id, enabled):
         """
         Turn Octopus Smart Control on (UNSUSPEND) or off (SUSPEND) for an intelligent device, and show it on the switch
         once Octopus accepts it. If Octopus rejects it the switch is left as it was.
+
+        It is sent even when the device already shows the asked-for state: that state can be up to a poll old, so
+        skipping it could drop a change the user really asked for.
         """
         device = self.intelligent_devices.get(device_id)
         if not device:
@@ -1653,9 +1656,9 @@ def build_discovery(self):
 
         One `cars` record per ACTIVE (non-suspended) intelligent device: get_active_intelligent_device_ids()
         is the exact filter automatic_config() itself applies when wiring the car slots into
-        apps.yaml, so the catalogue never lists a slot that is no longer being wired. Its three
-        entities (octopus_intelligent_slot, octopus_ready_time, octopus_charge_limit - see
-        OCTOPUS_CAR_ENTITY_SPEC) are included only when they actually exist in the state store:
+        apps.yaml, so the catalogue never lists a slot that is no longer being wired. Its four
+        entities (octopus_intelligent_slot, octopus_intelligent_smart_control, octopus_ready_time,
+        octopus_charge_limit - see OCTOPUS_CAR_ENTITY_SPEC) are included only when they actually exist in the state store:
         async_intelligent_update_sensor() publishes them per device, never as a fixed set, so the
         catalogue must not claim one exists that Home Assistant has never seen. Vehicle battery
         size and charge-point power are reported in ratings where Octopus's own vehicle/charger

apps/predbat/tests/test_octopus_smart_control_switch.py

@@ -175,7 +175,6 @@ async def _switch_back_on_while_sending(query, *args, **kwargs):
 
     print("Test 6: events for other entities, other services and unknown devices are ignored")
     api.commands = []
-    api.smart_control_confirmed = {}
     await api.switch_event("switch.predbat_octopus_acc_1_something_else_1001", "turn_off")
     await api.switch_event(active_switch, "bogus")
     await api.switch_event(api.get_entity_name("switch", "intelligent_smart_charge", index="9999"), "turn_off")