fix(compare): spell out which config: values mean no overrides (#5472)

Review follow-up. Only None, "", [] and {} count as an empty config:
and are dropped; any other non-mapping (false, 0, a string, a list) is
skipped with a warning instead of silently losing the overrides.
check_compare_list()'s docstring now states the shape it guarantees,
and the comment names where a list config really crashed (overrides
looked up by key in run_all()/fetch_config()).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: chalfontchubby

apps/predbat/compare.py

@@ -28,7 +28,11 @@
 
 
 def check_compare_list(compare_list):
-    """Split compare_list into the entries that can be compared (ids and names as strings) and a message per skipped entry (#5472)."""
+    """Split compare_list into the entries that can be compared and a message per skipped entry (#5472).
+
+    Each kept entry is a copy with its id and name as stripped strings, and its config either a
+    mapping of overrides or absent, so run_all() and fetch_config() can rely on that shape.
+    """
     if not compare_list:
         return [], []
     if not isinstance(compare_list, list):
@@ -54,17 +58,17 @@ def check_compare_list(compare_list):
                 problem = "has a duplicate id '{}'".format(entry_id)
             elif not entry_name:
                 problem = "('{}') requires a non-empty 'name'".format(entry_id)
-            elif entry.get("config") and not isinstance(entry["config"], dict):
-                # run_all() snapshots each override by key before any tariff runs, outside every try,
-                # so a list of overrides there crashed the whole comparison
+            elif entry.get("config") not in (None, "", []) and not isinstance(entry["config"], dict):
+                # run_all() and fetch_config() look overrides up by key; a list of them raised TypeError
+                # there and ended the whole comparison, and any other value was never a usable override
                 problem = "('{}') has a 'config' that isn't a set of 'setting: value' overrides".format(entry_id)
         if problem:
             problems.append("compare_list entry {} {}".format(index + 1, problem))
             continue
         seen_ids.add(entry_id)
         checked = dict(entry, id=entry_id, name=entry_name)
         if not checked.get("config"):
-            # An empty 'config:' line (None, [] or "") means no overrides, as it always has
+            # An empty 'config:' line (None, "", [] or {}) means no overrides, as it always has
             checked.pop("config", None)
         valid.append(checked)
     return valid, problems

apps/predbat/tests/test_compare.py

@@ -743,19 +743,23 @@ def _mock_plan_iboost_smart():
         {"id": "bad_config", "name": "Bad Config", "config": ["metric_battery_cycle"]},
         {"id": "empty_config", "name": "Empty Config", "config": None},
         {"id": "empty_list_config", "name": "  Empty List Config  ", "config": []},
+        {"id": "empty_string_config", "name": "Empty String Config", "config": ""},
+        {"id": "empty_dict_config", "name": "Empty Dict Config", "config": {}},
+        {"id": "false_config", "name": "False Config", "config": False},
+        {"id": "string_config", "name": "String Config", "config": "best_soc_min: 2.0"},
     ]
     kept = valid_compare_list(entries, log=logged.append)
     kept_ids = [entry["id"] for entry in kept]
     skipped_positions = sorted(int(msg.split("compare_list entry ")[1].split(" ")[0]) for msg in logged)
 
-    if kept_ids != ["agile", "2024", "numeric_name", "empty_config", "empty_list_config"]:
-        print("ERROR T27: valid_compare_list() should keep only 'agile', '2024', 'numeric_name', 'empty_config' and 'empty_list_config' (ids as strings), got {}".format(kept_ids))
+    if kept_ids != ["agile", "2024", "numeric_name", "empty_config", "empty_list_config", "empty_string_config", "empty_dict_config"]:
+        print("ERROR T27: valid_compare_list() should keep only 'agile', '2024', 'numeric_name' and the four empty-config entries (ids as strings), got {}".format(kept_ids))
         failed += 1
-    elif skipped_positions != [1, 2, 3, 5, 6, 8, 10, 11]:
-        print("ERROR T27: valid_compare_list() should warn for entries 1, 2, 3, 5, 6, 8 (padded duplicate id), 10 (blank name) and 11 (non-mapping config), got {}".format(logged))
+    elif skipped_positions != [1, 2, 3, 5, 6, 8, 10, 11, 16, 17]:
+        print("ERROR T27: valid_compare_list() should warn for entries 1, 2, 3, 5, 6, 8 (padded duplicate id), 10 (blank name), 11, 16 and 17 (unusable config), got {}".format(logged))
         failed += 1
-    elif "config" in kept[3] or "config" in kept[4]:
-        print("ERROR T27: an empty 'config:' (None or []) should be dropped as no overrides, got {} / {}".format(kept[3], kept[4]))
+    elif any("config" in entry for entry in kept[3:7]):
+        print("ERROR T27: an empty 'config:' (None, [], \"\" or {{}}) should be dropped as no overrides, got {}".format(kept[3:7]))
         failed += 1
     elif kept[4]["name"] != "Empty List Config":
         print("ERROR T27: a kept entry's name should be stripped, got {!r}".format(kept[4]["name"]))