Repository navigation
Fix free electricity session detection by using Go API - #2648
Merged
springfall2008 merged 1 commit intoSep 13, 2025
Merged
Conversation
- Replace DOM-dependent HTML parsing with Go API integration - Use dedicated octopus-free-sessions service for reliable parsing - Add fallback to legacy HTML parsing for backward compatibility - Improve session data format conversion with proper timezone handling - This resolves issues where free sessions weren't being detected due to changes in Octopus Energy website HTML structure The Go API uses goquery for better DOM parsing and will be upgraded to use proper CSS rendering in the future for maximum reliability.
mgazza
force-pushed
the
fix-free-electricity-sessions
branch
from
September 9, 2025 12:53
d37eae2 to
985d0e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
PredBat was failing to detect Octopus Energy free electricity sessions because the existing HTML parsing relied on specific DOM structure that broke when Octopus changed their webpage layout.
Solution
Test Plan
🤖 Generated with Claude Code