Skip to content

Increase timeout on Predbat hasn't updated time to 15 mins - #2799

Merged
springfall2008 merged 4 commits into
mainfrom
fixes3
Oct 21, 2025
Merged

springfall2008 merged 4 commits into
mainfrom
fixes3

Conversation

@springfall2008

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the timeout threshold for detecting whether Predbat is actively running from 6 minutes to 15 minutes, and fixes incorrect unit specifications in discharge rate percentage handling.

Key Changes:

  • Extended the staleness check timeout from 360 seconds (6 minutes) to 900 seconds (15 minutes)
  • Corrected required_unit parameter from "W" to "%" for discharge rate percentage operations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/predbat/predbat.py Updated version to v8.26.1 and increased timeout threshold from 6 to 15 minutes in the is_running() method
apps/predbat/inverter.py Fixed incorrect required_unit parameters for charge and discharge rate percentage operations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@springfall2008
springfall2008 merged commit 1bba738 into main Oct 21, 2025
1 check passed
@springfall2008
springfall2008 deleted the fixes3 branch October 21, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants