Repository navigation
Fix carbon component timeout - #2818
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a timeout issue with the carbon component by adjusting how the component tracks its last update time. The key change is separating the concepts of "last successful data fetch" from "last timestamp checked," preventing unnecessary API calls when cached data is still valid.
- Introduces a new
last_updated_timestampfield to track when data was last fetched - Updates
last_success_timestampeven when using cached data to prevent false timeout alerts - Changes status message from "(with errors)" to "(unhealthy)" for clarity
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/predbat/carbon.py | Adds last_updated_timestamp tracking and updates last_success_timestamp on cache hits to prevent timeout issues |
| apps/predbat/predbat.py | Bumps version number to v8.26.4 |
| apps/predbat/web.py | Updates error message from "(with errors)" to "(unhealthy)" for improved clarity |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.