Repository navigation
Decouple octopus direct from Predbat using database - #2825
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR decouples Octopus Direct from Predbat by implementing database-based entity storage, enabling Predbat to consume Octopus data through entities rather than direct API coupling. The changes introduce automatic configuration of entities, support for setting intelligent charging targets through entities, and improved command processing.
Key Changes:
- Added automatic entity configuration system that populates Predbat's arguments with dynamically generated entity names
- Implemented entity-based controls for intelligent charging (target time/SOC) and saving session management
- Refactored rate data storage to use structured list format with start/end timestamps instead of dictionary keys
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/predbat/octopus.py | Core changes implementing entity-based interface, command queue system, automatic configuration, and intelligent charging controls |
| apps/predbat/predbat.py | Added tracking for saving session join attempts to prevent spam |
| apps/predbat/fetch.py | Removed direct Octopus API coupling, now exclusively uses entity-based data access |
| apps/predbat/web.py | Updated regex pattern and entity type checks to support new entity types |
| apps/predbat/components.py | Added automatic configuration option for Octopus component |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.