Repository navigation
Fix bug with Octopus direct after re-factor - #2854
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the version number and refactors how Octopus Energy tariff data is handled in the automatic configuration system. The changes simplify metric naming conventions and modify how rates and standing charges are converted from pence to pounds.
- Version bump from v8.27.2 to v8.27.3
- Refactored config key naming for Octopus metrics (from
metric_octopus_{tariff}_ratestometric_octopus_{tariff}) - Modified rate value conversion to divide by 100 and apply dp2 formatting
- Added standing charge only for import tariffs in automatic config
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/predbat/predbat.py | Version number updated to v8.27.3 |
| apps/predbat/octopus.py | Refactored metric naming, changed rate/standing charge conversion logic, and restricted standing charge config to import tariffs only |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.