Repository navigation
Cleanup inverter SN handling in Solis - #3864
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up Solis inverter serial-number handling so the component keeps the configured SN filter separate from the runtime-discovered inverter list. In the Solis integration, that makes startup/retry discovery more robust when run() mutates self.inverter_sn.
Changes:
- Split configured Solis inverter SNs from discovered/managed inverter SNs by introducing
configured_inverter_sn. - Centralized discovery filtering in
filter_inverter_sn(), including case-insensitive matching and missing-SN warnings. - Added Solis tests covering SN filtering and first/subsequent
run()behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
apps/predbat/solis.py |
Refactors Solis SN initialization/discovery to preserve configured filters across retries. |
apps/predbat/tests/test_solis.py |
Adds regression tests for SN filtering and run() lifecycle behavior. |
apps/predbat/predbat.py |
Bumps the app version for this Solis change. |
| self.max_charge_current = {} # {inverter_sn: int} | ||
| self.max_discharge_current = {} # {inverter_sn: int} | ||
| self.charge_discharge_time_windows = {} # {inverter_sn: time_window_dict} | ||
| self.inverter_sn = [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.