Skip to content

fix: add timeout to requests.get() in futurerate.py and octopus.py #4539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
springfall2008 merged 8 commits into from
Aug 16, 2026
Merged

fix: add timeout to requests.get() in futurerate.py and octopus.py #4539

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
075f152
Initial plan
Copilot Aug 15, 2026
fdcad07
fix: add timeout=30 to requests.get() in futurerate.py and octopus.py…
Copilot Aug 15, 2026
44cc37c
Increase timeout for downloading futurerate data
springfall2008 Aug 16, 2026
0e89aeb
Increase fresh_minutes for octopus data caching
springfall2008 Aug 16, 2026
7396ab5
Add timeout coverage for Nord Pool and Octopus tests
Copilot Aug 16, 2026
166a700
Update octopus.py
springfall2008 Aug 16, 2026
16132f9
Reduce fresh_minutes for octopus data caching
springfall2008 Aug 16, 2026
e685ff9
Change expected timeout from 30 to 120 seconds
springfall2008 Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/predbat/futurerate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ def download_futurerate_data(self, url):

def download_futurerate_data_func(self, url):
try:
r = requests.get(url)
r = requests.get(url, timeout=120)
Comment thread
springfall2008 marked this conversation as resolved.
except Exception as e:
self.log("Warn: Error downloading futurerate data from URL {}, request exception {}".format(url, e))
self.record_status("Warn: Error downloading futurerate data from cloud", debug=url, had_errors=True)
Expand Down
2 changes: 1 addition & 1 deletion apps/predbat/octopus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2066,7 +2066,7 @@ def download_octopus_free_func(self, url):
Download octopus free session data directly from a URL, no caching.
"""
try:
r = requests.get(url)
r = requests.get(url, timeout=30)
except requests.exceptions.ConnectionError:
self.log("Warn: Octopus: Unable to download Octopus data from URL {} (ConnectionError)".format(url))
self.record_status("Warn: Unable to download Octopus free session data", debug=url, had_errors=True)
Comment thread
springfall2008 marked this conversation as resolved.
Expand Down
Loading