feat(teslemetry): enable teslemetry_tbc_control by default

[springfall2008]

This is an automated draft PR generated from issue #5186 — a maintainer should review it before merging.

Fixes #5186

Summary

Makes teslemetry_tbc_control on by default. Before this it was an opt-in trial setting, added in PR #4976 for GH#4892. If apps.yaml doesn't set the key, the Teslemetry component now pushes the signal tariff (0p over the charge window, 50p import elsewhere, 100p over the export window) and puts the Powerwall in autonomous mode, so Tesla's Opticaster charges at full rate. Setting teslemetry_tbc_control: False explicitly still gives the real-rate tariff and reserve-driven charging.

• apps/predbat/components.py: registry default for tbc_control changed from False to True. This is the functional change: Components.start() resolves an unset key to this value (components.py:806).
• apps/predbat/teslemetry.py: initialize()'s own tbc_control default also changed to True, and the docstring updated. Production always passes the registry value, so this doesn't change production behaviour. It keeps a direct construction on the same path as production; the __main__ CLI test run builds the class without passing tbc_control.
• templates/teslemetry.yaml: the commented #teslemetry_tbc_control: True hint is replaced with a commented opt-out, #teslemetry_tbc_control: False.
• docs/components.md and docs/inverter-setup.md: the defaults table, the "Important notes" tariff bullets and the Teslemetry setup section now describe the setting as on by default, with an opt-out. The setup section's example YAML previously had an uncommented teslemetry_tbc_control: False, so anyone copying it would have stayed opted out. That line is now a commented opt-out.

Testing

• ./run_pre_commit (from coverage/): every hook passed, and run_all --quick passed (4 slow tests skipped). I ran it before and after the self-review edits.
• tools/triage_test.sh teslemetry: fails without the fix and passes with it. With only components.py and teslemetry.py stashed, the new test_teslemetry_tbc_control_defaults_on_via_the_registry fails at assert api.tbc_control is True. With the fix restored, the module passes.
• tools/triage_test.sh components: passes (9/9).

Test changes in apps/predbat/tests/test_teslemetry.py:

• New: test_teslemetry_tbc_control_defaults_on_via_the_registry. Takes the registry default, passes it through initialize(), and checks the TBC path is selected (autonomous mode inside a charge window). It also checks that a bare initialize() agrees with the registry default.
• Renamed: test_teslemetry_tbc_control_defaults_off_and_uses_the_real_rate_tariff is now test_teslemetry_tbc_control_off_uses_the_real_rate_tariff, and it sets tbc_control = False explicitly. It now tests the opt-out rather than a default.
• Extended: test_teslemetry_initialize_sets_tbc_control_from_component_arg now also asserts that initialize(tbc_control=False) is honoured.
• Updated: test_teslemetry_component_registry_config now pins the registry default as True.

Notes

• Who is affected. The emulator loop in run() (teslemetry.py:508) is gated on read-only mode but not on teslemetry_automatic. So after upgrading, every non-read-only Teslemetry user who hasn't set the key moves to the signal tariff and autonomous mode on their first cycle. That includes users who don't have teslemetry_automatic: True. The triage comment said only automatic users would be affected; that isn't quite right. Two visible changes: the Tesla app will show the 0/50/100p signal tariff instead of the user's real rates, and Predbat's charge and export targets become advisory. Probably worth a line in the release notes.
• 81-99% reserve limitation, now on by default. The limitation documented in docs/inverter-setup.md now applies to anyone on the default: with set_reserve_min anywhere in 81-99, grid charging stays disabled in every state, and the only explanation is a one-off log line. This PR doesn't change that behaviour. It's a judgement for the maintainer whether that needs a louder diagnostic before the setting defaults on.
• Two defaults I left alone.
  • The getattr(self, "tbc_control", False) fallbacks in evaluate_schedule and sync_tariff (teslemetry.py:592/:1414) still default to False. They can't be reached in production, because initialize() always sets the attribute, so I kept this change scoped.
  • MockTeslemetryAPI still sets tbc_control = False, so the roughly 100 existing tests written against the real-rate path keep testing it. A comment on the mock says why, and the TBC tests opt in explicitly.
• Related: Teslemetry: flat-priced tariff across the whole export window lets Tesla's own TBC defer most of the discharge to the last ~30 minutes #4887. That issue (a flat ON_PEAK band on the real-rate tariff path) now only affects users who opt out.
• Blast radius. GitNexus impact on TeslemetryAPI.initialize is LOW with no static callers; the registry constructs the class dynamically. COMPONENT_LIST is a data constant that GitNexus can't resolve as a target, so I found its readers by search: the registry resolver (components.py:806), the web component-config view (web.py:5483, which only displays the default), and the tests. detect_changes: LOW risk, 0 affected execution flows.
• The Teslemetry entry in tools/debug-journal.md informed this change: it describes the TBC path and the 81-99% rounding.

🤖 Generated with Claude Code

[Copilot]

Copilot review overview

🔵 Needs a closer look

The registry-to-constructor default wiring is not directly covered by the test, and the related lifecycle docstring needs correction.

Review effort: Lite
Findings: None

What changed in this PR

Enables Teslemetry Time-Based Control by default while retaining an explicit opt-out.

Changes:

• Updates registry and initialization defaults to True.
• Documents the new default and opt-out configuration.
• Updates tests for default-on and explicit-off behavior.

File	Summary
templates/​teslemetry.yaml	Adds a commented opt-out configuration.
docs/​inverter-setup.md	Documents default-on behavior, opt-out guidance, and limitations.
docs/​components.md	Updates component defaults and tariff behavior.
apps/​predbat/​tests/​test_teslemetry.py	Updates default and opt-out tests. A moderate issue remains: the test does not exercise Components.initialize() default resolution; a docstring lifecycle reference also needs correction.
apps/​predbat/​teslemetry.py	Aligns direct initialization with the new default.
apps/​predbat/​components.py	Enables TBC by default in the component registry.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.