Repository navigation
test(validate): pin the repeated entity pointer for per-car sensor args - #5191
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
car_charging_battery_sizeandcar_charging_limitaresensor-typed keys withentries: num_cars, so a scalar fails validation as soon as runtimenum_cars > 1("Invalid type, expected list"). Anything publishing one of these as a pointer to a
single entity therefore has to emit a list, and rely on two behaviours that nothing
currently pins:
num_carsrather than rejecting it, so afixed-length list is safe at any car count; and
resolves per car.
This adds a case to
test_validate_configcovering both. It seeds one sensor andpoints every slot at it, then checks
num_cars0, 1, 2 and 8 all validate, that abare scalar still fails at 2, and that each slot resolves through
get_arg(..., index=slot)as a float — the fractional value matters, since an int defaultsilently truncates a 10.5 kWh battery to 10.
No production code changes.
Follow-up to #5117, which fixed the gateway's unindexed read of the same key. The
test was written alongside that fix but landed after it merged, so it needs its own
PR.