Repository navigation
fix(gecloud): parse the integer rating of 3-phase hybrid models (GIV-3HY-11) - #5293
Merged
Merged
Conversation
…3HY-11) instead of falling back to max_charge_rate Fixes #5136 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
springfall2008
marked this pull request as ready for review
September 28, 2026 19:05
springfall2008
commented
Sep 28, 2026
springfall2008
commented
Sep 28, 2026
springfall2008
commented
Sep 28, 2026
springfall2008
commented
Sep 28, 2026
springfall2008
commented
Sep 28, 2026
springfall2008
commented
Sep 28, 2026
springfall2008
commented
Sep 28, 2026
springfall2008
commented
Sep 28, 2026
…punctuation, 3HY before decimal, readable fallback warning, publish_info tests Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Sep 30, 2026
springfall2008
added a commit
that referenced
this pull request
Oct 2, 2026
…0-01 docs(debug-journal): fold in the 2026-10-01 queue slice (9 candidates); mark GH#5313 fixed by PR #5315, GH#5136 by PR #5293, GH#5222 by PR #5283, the iog-slot-io-adjusted row by PR #5304, GH#5068 reworked by PRs #5309/#5314; add the dynamic-load car cancel row and the GH#2649/#5302/#5324 findings
gcoan
pushed a commit
to gcoan/batpred
that referenced
this pull request
Oct 3, 2026
…); mark GH#5313 fixed by PR springfall2008#5315, GH#5136 by PR springfall2008#5293, GH#5222 by PR springfall2008#5283, the iog-slot-io-adjusted row by PR springfall2008#5304, GH#5068 reworked by PRs springfall2008#5309/springfall2008#5314; add the dynamic-load car cancel row and the GH#2649/springfall2008#5302/springfall2008#5324 findings Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated draft PR generated from issue #5136 — a maintainer should review it before merging.
Fixes #5136
Summary
get_max_inverter_rate_from_model()only recognised decimal ratings, soGIV-3HY-11(11 kW 3-phase hybrid) fell through tomax_charge_rate. That value is a battery figure, and GE Cloud reports it variously as 9984, 7987 or 11000 W on 11 kW units. It then went intoinverter_limitand understated the clipping and export ceiling in the plan.Following the approach recommended in the 2026-09-28 comment on the issue:
3HY-:(?:^|-)3HY-(\d{1,2})(?=-|$), case-insensitive. A "last integer" rule would have misreadGIV-AIO-GW2as 2 kW. This pass cannot matchGW2orG3-style suffixes.max_charge_ratefallback.HYstill falls back, it logs one warning per model. A future naming scheme will then show up in the log, where today the limit is silently wrong.Testing
./run_pre_commit(fromcoverage/): all hooks passed, and the quick suite reported "All tests passed"._test_get_max_inverter_rate_from_model(ge_cloudsuite):GIV-3HY-11→ 11000,GIV-3HY-8→ 8000,giv-3hy-5→ 5000GIV-AIO-GW2,GIV-3HY-G3andGIV-3HY-110keep the fallbackALPS HY-6.0-GL→ 6000 (the decimal pass still wins)Gateway) stays silentgecloud.pystashed,tools/triage_test.sh ge_cloudgave 123 passed, 1 failed. The 3HY rows returned 9984/7987/4000 and no warning was logged.Notes
max_discharge_ratewas deliberately not adopted as the fallback. It is still a battery figure rather than an AC rating, and switching to it would change behaviour for every digit-less model. Both the triage comment and the follow-up flagged this as a decision for the maintainer.GIV-3HY-8andGIV-3HY-5strings are assumed formats, because onlyGIV-3HY-11has been observed. The anchored regex accepts any 1–2 digit segment after3HY-.impactrated this LOW. By search, the only production caller ispublish_info()(gecloud.py).detect_changesreports low risk and no affected processes.model_rate_warnedset is initialised inGECloudDirect.initialize()and mirrored in theMockGECloudDirecttest double, the same way as the existingvalidation_parse_warned.🤖 Generated with Claude Code