Repository navigation
Fix freeze export at 100% SoC - #5469
Open
Ajayreddy18 wants to merge 1 commit into
Open
Ajayreddy18 wants to merge 1 commit into
Ajayreddy18 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The Solis FB00 control path still excludes freeze requests at a 100% target.
1 open finding
What changed in this PR
Fixes freeze-export service handling when the target SoC is 100%.
Changes:
- Allows explicit freeze requests into the export-freeze branch.
- Adds a regression test for the 100% target.
| File | Description |
|---|---|
apps/predbat/inverter.py |
Updates export-freeze branching. |
apps/predbat/tests/test_inverter.py |
Adds the regression case. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| service_data_stop = {"device_id": self.base.get_arg("device_id", index=self.id, default="")} | ||
| extra_data = {"discharge_start_time": self.base.get_arg("discharge_start_time", index=self.id, default="00:00:00"), "discharge_end_time": self.base.get_arg("discharge_end_time", index=self.id, default="00:00:00")} | ||
| if target_soc < 100: | ||
| if target_soc < 100 or freeze: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Fixes #5302.