Repository navigation
docs: show car_charging_now per charger, and how to share one charger between cars - #5476
Open
chalfontchubby wants to merge 3 commits into
Open
chalfontchubby wants to merge 3 commits into
chalfontchubby wants to merge 3 commits into
Conversation
… between cars
car_charging_now is what makes Predbat hold the house battery while a car is
actually drawing power, but devices.md only showed it for some chargers.
devices.md: a short pointer to the car_charging_now reference, a note that
the *_response lists are global (merge, don't replace), and examples for
the Ohme built-in integration and the Zappi. Also fix the Zappi
car_charging_planned regex, whose stray ')' made it an invalid expression
("unbalanced parenthesis").
car-charging.md: under Multiple Electric Cars, a recipe for one charger
shared by two cars (#5467). A single charger sensor listed for both cars
reads both as plugged in or charging, and car_charging_exclusive then plans
car 0 whichever car is on the charger. The recipe gives each car its own
template sensors, gated by an input_select naming the car on the charger,
and states where it does not apply (Predbat's own charger integrations, and
a charger enrolled on its own with Octopus Intelligent).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Most inverter templates already list 'ev ready to charge' in car_charging_planned_response; only the default apps.yaml leaves it out, so say "make sure your list includes it" rather than "add that one". With more than one Zappi, car_charging_energy's re: also resolves to a single session sensor, so tell users to list every Zappi's session sensor there too (minute_data_import_export sums them). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… rather than keeping yours gateway.py writes car_charging_now with set_arg, which overwrites, unlike the Ohme, myenergi and Wallbox integrations (set_arg_auto with overwrite=False). The devices.md overview added in this PR links here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation matches the implemented configuration and charging behavior, with no unresolved issues found.
0 open findings
What changed in this PR
Documents live EV charging detection and shared-charger configuration, addressing the setup gap highlighted by #5467.
Changes:
- Adds Ohme and Zappi
car_charging_nowguidance and fixes the Zappi regex. - Adds a multi-car shared-charger recipe with guarded template sensors.
| File | Description |
|---|---|
docs/devices.md |
Expands charger-specific configuration guidance. |
docs/car-charging.md |
Documents per-car settings and shared-charger setup. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Posted by Claude on behalf of @chalfontchubby.
Why
car_charging_now is what makes Predbat hold the house battery while a car is actually drawing power. It also catches a charge someone starts by hand. devices.md only showed it for Hypervolt, PodPoint, Wallbox and the old Ohme HACS integration.
#5467 showed another gap: two cars sharing one Zappi. A single charger sensor listed for both cars reads both as plugged in or charging.
car_charging_exclusivethen plans car 0 whichever car is actually on the charger. The docs didn't explain how to handle that.What changes (docs only)
docs/devices.mdcar_charging_nowreference;car_charging_now_responseandcar_charging_planned_responseare each one list for every car, so values from a device example should be merged into the user's list, not replace it;car_charging_nowfromsensor.ohme_{ohme_name}_status, which readscharging, with a note on Ohme Direct.car_charging_nowfrom the plug status;ev ready to charge, which the template's planned-response list lacks;re:picks an unpredictable match when there are several Zappis, and thatmyenergi_automaticsets these values itself.car_charging_plannedexample was're:sensor.myenergi_zappi_[0-9a-z]+_plug_status)'. The stray)makes it an invalid regular expression (re.error: unbalanced parenthesis), so anyone who copied it got no plug detection.docs/car-charging.mdcar_charging_nowto the list of per-car settings under Multiple Electric Cars.input_selectnaming the car on the charger, with availability guards andcar_charging_exclusivekept on;Tesla has no example: I couldn't confirm an entity name for its integrations.
How to check
Docs only, and pre-commit passes (markdownlint, cspell). I ran several local
/code-review highpasses and checked the claims against the code:exclusiveloop (fetch.py);*_responsedefaults;overwrite=Falsefor acar_charging_nowthe user has set;ignore_unpluggedgating;All anchors used match existing headings.
🤖 Generated with Claude Code