Repository navigation
docs: keep compare_tariff sensors in the FAQ recorder example - #5487
Merged
Merged
Conversation
The FAQ's recorder example excludes the predbat domain and re-includes only a fixed entity list, which leaves out predbat.compare_tariff_*. The Compare tab builds its day-by-day history from those sensors' recorded history, so anyone copying the example only ever sees the latest compare run. Add an entity_globs include for predbat.compare_tariff_*, say why in the FAQ's caveats, and note the recorder requirement in compare.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chalfontchubby
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened by Claude on Rik's behalf.
Fixes #5485
Problem
The FAQ's
recorder:example excludes the wholepredbatdomain and only includes a fixed list of entities, andpredbat.compare_tariff_*isn't on that list. The Compare tab builds its day-by-day history from the recorded history of those sensors (get_history_wrapper(result["entity_id"], 28)inweb.py). Predbat itself keeps only the latest run, incomparisons.yaml. So anyone who copies the FAQ example sees only last night's comparison, and it gets replaced every night.The reporter in #5485 had copied the FAQ block word for word. Their log shows all four comparisons completing normally every run, and their HA history graph for a compare sensor is flat apart from one old value.
Change
docs/faq.md: addentity_globs: - predbat.compare_tariff_*underinclude:in the recorder example. In HA's filter order an include glob is checked before the excluded domain, so this restores recording. Also add a line to the "be careful if you adapt this" notes.docs/compare.md: note that the compare sensors must be kept by the recorder, linking to the FAQ example.Docs only, no code change.
🤖 Generated with Claude Code