Repository navigation
docs(debug-journal): fold in the 2026-10-11 queue remainder (5 candidates); mark GH#5471 fixed in PR #5475 - #5495
Merged
Conversation
…ates); mark GH#5471 fixed in PR #5475 Co-Authored-By: Claude Code <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Automated journal-update run for 2026-10-12 — this PR was opened by the triage bot; a human merge is the review gate on
tools/debug-journal.md.Queue:
/Users/treforsouthwell/predbat-triage-bot/journal-queuewith a 15-candidate limit; the directory held 5 candidates (all from the 2026-10-11 triage round), so this PR folds in the whole current queue — 0 left queued.Per-candidate outcomes
5483-predheat-load-forecast-wiring-exists.mdpredheat.heat_energy$externalfeeds the plan's forward load, LoadML is additive, not exclusive (fetch_extra_load_forecast()sums ML + everyload_forecastentity;load_forecast_onlyonly zeroes the historical component), double-count caveat viacar_charging_energy. Verified end to end ond7d8c607(predheat.py publish path,fetch_extra_load_forecast,get_from_incrementing, predbat.py instantiation, both doc pages). Fold-in note: one candidate claim drifted — theload_forecast_onlyvariant is documented indocs/apps-yaml.mdonly, not both pages as the candidate said.5485-compare-chart-bars-are-recorder-rows.mdpredbat.compare_tariff_<id>(get_history_wrapper+history_attribute(daily=True, first=True)keeps the first state per local day), the nightly run writes once/night (publish_only()suppresses), a render-time "today" point always renders, so missing groups map to recorder/nightly-run causes and the Avg7(Nd)column is a no-files diagnostic. All symbols verified ond7d8c607(web.pychart path,history_attributeday bucketing,predbat.pymidnight gate,const.py,history_daily_at_hour).5489-update-entity-skip-hardcoded-auto-update.mdupdate.predbat_versionstarts at the hardcodedauto_update: True(userinterface.py, deliberate since #727); HA's skip button blocks on exactly that attribute and not on the no-unique_id limitation (the two are separate);update.skipis captured butupdate_event()'s skip branch is a stub; any fix must persistskipped_versionPredbat-side (Storage) and republish it. Verified ond7d8c607(userinterface.pyupdate branch/listeners/stub,github.pypublish,config.pyitem).5490-import-limit-ratings-only-no-planner-cap.mdimport_limitis per-inverter discovery ratings only (sunsynk/fox/deye), noconfig.pysetting, prediction clamps export only (prediction.py); maps to "no such setting exists", with the recorded direction = draft PR #5486 + the GH#1199 design note (GH#5490 umbrella, GH#2449/#1199 family; car-planner ranking is the GH#5384 entry). Re-verified ond6985b6d(grep: ratings-only; no config item;prediction.pyclamp). PR #5486 re-checked today: still draft, proposes diagnostics-only with no enforcement.5492-...-partial-response.mdignore_errors=True+ "returndatawhenever present" = the caller can't seeerrors), theor []turns a blip'snullinto a real[]stored over the cache (slots/cheap rate vanish one cycle, 2 extra replans; the issue's log measured 7/230) — PR #5250's fallback covers onlyNone; fix = route the null into it. Kraken contrast kept (kraken returns None on anyerrors, cache survives). Verified ond6985b6d(octopus.py:2401/2409/2496/2498/2554/2604-2620 area, kraken.py:375-378, Test 14).What was dropped
Nothing dropped — all five candidates passed verification. One claim was corrected at fold-in (5483's doc claim, above). The 5492 candidate's aside on the charging-now rate ratchet (
car_charging_rateraised tomax(Octopus kW, configured)) was not folded because the Octopus row's GH#5438 entry already covers that mechanism — no second entry needed.Journal re-check vs merges since the last journal PR
Only one commit merged after yesterday's journal PR (f20ddaf, 18:54) — PR #5475 (d6985b6, 19:40), which fixes GH#5471 exactly as yesterday's entry said "fix in flight". Corrected:
d6985b6d(gateway.py rebased code, octopus.py byte-identical across the range, docs commits touching no journal-claimed behaviour).Quality gate
Pre-commit run per
coverage/run_pre_commit(hooks stage): markdownlint, cspell, ruff, black, export-limit checks, triage daemon tests — all green, no dictionary additions needed. The merged gateway fix's own tests ran in that PR's CI; no code changes in this PR.🤖 Generated with Claude Code