Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud and Hub discovery currently write the same optimiser arguments, so configuring both can replace one provider's mappings with the other's. This increment captures each provider's real discovery separately, deduplicates complete physical inverter identities and composes only the effective primary into stable optimiser slots. Actual Cloud HTTP attempts and Hub MQTT commands enforce that selection, including retries and background defaults.
Gateway endpoint IDs and credential references stay distinct. Standby connections remain configured. Global optimiser slots resolve to the correct Hub-local serial for rate caps. Aggregate actuation and executable plans without proven per-inverter scope are refused.
Validation: 478 tests and 19 subtests passed, including existing source-control and display regressions; pre-commit passed. One pre-existing custom-runner fixture test is excluded from the pytest invocation. GitNexus reports five expected discovery/control flows, medium risk.
Draft stacked on #5525. This is the runtime foundation only: no startup installer, service-issued per-inverter authority, enabled selector, activation or production enrollment. The next integration must validate the real SQL/config/startup/physical transport path and exclusive handoff before selection is usable. Synthetic transport responses in tests do not prove physical hardware or multi-inverter meter ownership.