Repository navigation
fix(inverter): hold software-controlled charging after target overshoot - #5541
Open
Jeff-Bond-UK wants to merge 1 commit into
Open
Jeff-Bond-UK wants to merge 1 commit into
Jeff-Bond-UK wants to merge 1 commit into
Conversation
Author
|
@springfall2008, my Reviewers control is disabled on this PR. Could you formally request a review from a maintainer, or review it yourself please? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an inverter without native target-SoC control overshoots its charge target between Predbat updates,
adjust_charge_immediate()callscharge_stop_service. If that service restores self-consumption, the battery supplies the house until it falls below target and charging starts again. Reaching the target exactly already selects the configured freeze service.This change tries
charge_freeze_servicein the existing non-native, above-target branch, retainingcharge_stop_servicewhen no freeze service is configured. Native target-SoC control, exact-target handling, explicit freeze handling and discharge/export control keep their existing behaviour.Hardware evidence
Tested by the reporter on Anker SOLIX Solarbank 4 E5000 Pro with Predbat v9.3.8 and reserve control disabled. Log timestamps are Europe/London, 13 October 2026:
Only the above-target Hold charging behaviour changes in this PR. Explicit freeze observations demonstrate continued operation.
Validation
git diff --checkpasses.EALLOWGIT). No hook configuration was changed.--quicksuite passes: all tests passed, four slow tests skipped, total time 505.20 seconds.