fix(web): expose combined export methods on wrapper module - #76
Merged
Conversation
createSpzGatekeeperModule never forwarded inspectSpzWithCompatPtr / inspectCompatSummaryPtr. index.html's feature check (typeof wasmModule.inspectSpzWithCompatPtr === 'function') therefore failed and every 25MB v3 inspection ran the fallback path: inspectSpzPtr (full decompress) + inspectCompatSummary (full decompress) = 2 complete 31MB gunzips per review. That doubled the ~400ms real cost to ~800ms and left wasm_perf null (combined export never called). Forward both zero-copy methods so index.html uses the single-pass combined export (wasm_perf diagnostic becomes populated too).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createSpzGatekeeperModule never forwarded inspectSpzWithCompatPtr / inspectCompatSummaryPtr. index.html's feature check (typeof wasmModule.inspectSpzWithCompatPtr === 'function') therefore failed and every 25MB v3 inspection ran the fallback path: inspectSpzPtr (full decompress) + inspectCompatSummary (full decompress) = 2 complete 31MB gunzips per review. That doubled the real ~400ms cost to ~800ms and left wasm_perf null.
Forward both zero-copy methods so index.html uses the single-pass combined export.