refactor: update rimraf import and usage for consistency

Author: hebertcisco

script/command-executor.ts

@@ -20,7 +20,7 @@ const progress = require("progress");
 const prompt = require("prompt");
 import * as Q from "q";
 
-const rimraf = require("rimraf");
+const { rimraf } = require("rimraf");
 import * as semver from "semver";
 
 const Table = require("cli-table");
@@ -277,15 +277,7 @@ function deleteConnectionInfoCache(printMessage: boolean = true): void {
 }
 
 function deleteFolder(folderPath: string): Promise<void> {
-  return Promise<void>((resolve, reject, notify) => {
-    rimraf(folderPath, (err: any) => {
-      if (err) {
-        reject(err);
-      } else {
-        resolve(<void>null);
-      }
-    });
-  });
+  return rimraf(folderPath).then(() => undefined);
 }
 
 function deploymentAdd(command: cli.IDeploymentAddCommand): Promise<void> {

script/utils/file-utils.ts

@@ -1,6 +1,6 @@
 import * as fs from "fs";
 import * as path from "path";
-import * as rimraf from "rimraf";
+import { rimrafSync } from "rimraf";
 import * as temp from "temp";
 
 export function isBinaryOrZip(path: string): boolean {
@@ -22,7 +22,7 @@ export function fileExists(file: string): boolean {
 export function copyFileToTmpDir(filePath: string): string {
   if (!isDirectory(filePath)) {
     const outputFolderPath: string = temp.mkdirSync("code-push");
-    rimraf.sync(outputFolderPath);
+    rimrafSync(outputFolderPath);
     fs.mkdirSync(outputFolderPath);
 
     const outputFilePath: string = path.join(outputFolderPath, path.basename(filePath));