Skip to content

Install correct version of networking-mlnx for openstack release - #2548

Draft
jovial wants to merge 1 commit into
stackhpc/2026.1from
bugfix/2026.1/networking-mlnx
Draft

jovial wants to merge 1 commit into
stackhpc/2026.1from
bugfix/2026.1/networking-mlnx

Conversation

@jovial

@jovial jovial commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Updated neutron_mlnx_agent_pip_packages_override to use the stackhpc branch based on openstack_release.

@jovial
jovial requested a review from a team as a code owner August 25, 2026 10:55
@github-actions github-actions Bot added the waiting-review PR is waiting for a review label Aug 25, 2026
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: stackhpc/stackhpc-kayobe-config/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: ff14a096-3682-4ba8-8693-8d358e9ac8d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Summary

Update neutron_mlnx_agent_pip_packages_override to install the StackHPC networking-mlnx branch that matches the configured OpenStack release.

Walkthrough

The Kolla build configuration now installs networking-mlnx from the release-specific StackHPC branch instead of the upstream master branch.

Changes

MLNX package source selection

Layer / File(s) Summary
Update MLNX package override
etc/kayobe/kolla.yml
The networking-mlnx package reference now uses the stackhpc/{{ openstack_release }} branch.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: 🟡 Moderate · up to 468d4

The change can select a nonexistent networking-mlnx branch for the default OpenStack release, which may stop the MLNX image build. Update the release-to-branch mapping before merging.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

bbezak
bbezak previously approved these changes Aug 25, 2026
@jovial
jovial marked this pull request as draft August 25, 2026 10:58

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 56e17421-f7cd-422d-aa05-6a4d6228e5ca

📥 Commits

Reviewing files that changed from the base of the PR and between 7fa8c88 and 468d407.

📒 Files selected for processing (1)
  • etc/kayobe/kolla.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: stackhpc/check-review
  • GitHub Check: Build Kayobe Image / Build kayobe image
  • GitHub Check: stackhpc/check

Comment thread etc/kayobe/kolla.yml Outdated
@bbezak
bbezak self-requested a review August 25, 2026 11:02
@jovial
jovial force-pushed the bugfix/2026.1/networking-mlnx branch from 468d407 to 84b017a Compare August 25, 2026 11:04
@jovial

jovial commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

We likely need to restore the installation of networking-mlnx into neutron and nova containers since I believe they are not installed by default.

@jovial

jovial commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Will need to rebase on #2573 and rebuild.

@jovial
jovial changed the base branch from stackhpc/2026.1 to 2026.1-full-rebuild September 1, 2026 11:41
Comment thread etc/kayobe/kolla.yml Outdated
- python3-ethtool
neutron_mlnx_agent_pip_packages_override:
- networking-mlnx@git+https://opendev.org/x/networking-mlnx@master
- networking-mlnx@git+https://opendev.org/x/networking-mlnx@stable/{{ openstack_release }}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially this is the default. Its probably the neutron and nova plugins we need.

@jovial

jovial commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Trying to rebuild images again.

@Alex-Welsh
Alex-Welsh force-pushed the 2026.1-full-rebuild branch 2 times, most recently from d1ea65c to 6d43395 Compare September 3, 2026 13:09
Base automatically changed from 2026.1-full-rebuild to stackhpc/2026.1 September 3, 2026 20:15
@mnasiadka

Copy link
Copy Markdown
Member

Closing and reopening because there's a pep8 job stuck on zuul side.

@mnasiadka mnasiadka closed this Sep 10, 2026
@mnasiadka mnasiadka reopened this Sep 10, 2026
This was removed in the Gazpacho update. This restores the plugins into the
neutron and nova containers.
@jovial
jovial force-pushed the bugfix/2026.1/networking-mlnx branch from 1211643 to 05d3f42 Compare September 21, 2026 14:57
@jovial

jovial commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-review PR is waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants