Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: stackhpc/stackhpc-kayobe-config/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 SummaryUpdate WalkthroughThe Kolla build configuration now installs ChangesMLNX package source selection
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: 🟡 Moderate · up to The change can select a nonexistent networking-mlnx branch for the default OpenStack release, which may stop the MLNX image build. Update the release-to-branch mapping before merging. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 56e17421-f7cd-422d-aa05-6a4d6228e5ca
📒 Files selected for processing (1)
etc/kayobe/kolla.yml
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
- GitHub Check: stackhpc/check-review
- GitHub Check: Build Kayobe Image / Build kayobe image
- GitHub Check: stackhpc/check
468d407 to
84b017a
Compare
|
We likely need to restore the installation of networking-mlnx into neutron and nova containers since I believe they are not installed by default. |
|
Will need to rebase on #2573 and rebuild. |
| - python3-ethtool | ||
| neutron_mlnx_agent_pip_packages_override: | ||
| - networking-mlnx@git+https://opendev.org/x/networking-mlnx@master | ||
| - networking-mlnx@git+https://opendev.org/x/networking-mlnx@stable/{{ openstack_release }} |
There was a problem hiding this comment.
Potentially this is the default. Its probably the neutron and nova plugins we need.
|
Trying to rebuild images again. |
d1ea65c to
6d43395
Compare
|
Closing and reopening because there's a pep8 job stuck on zuul side. |
This was removed in the Gazpacho update. This restores the plugins into the neutron and nova containers.
1211643 to
05d3f42
Compare
|
Trying to rebuild here: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/35616612798 |
Updated neutron_mlnx_agent_pip_packages_override to use the stackhpc branch based on openstack_release.