fix(operator): warn when VirtualMCPServer inline telemetry is ignored - #6408
fix(operator): warn when VirtualMCPServer inline telemetry is ignored#6408RaviTharuma wants to merge 2 commits into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6408 +/- ##
==========================================
- Coverage 78.02% 78.00% -0.03%
==========================================
Files 767 767
Lines 74273 74284 +11
==========================================
- Hits 57955 57947 -8
- Misses 16313 16332 +19
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| usesIgnoredInline := vmcp.Spec.Config.Telemetry != nil && vmcp.Spec.TelemetryConfigRef == nil | ||
| r.emitInlineTelemetryIgnoredEvent(vmcp, usesIgnoredInline) |
There was a problem hiding this comment.
nit: this is passing both vmcp and a boolean calculated on its fields. Is there a reason why vmcp.Spec.Config.Telemetry and vmcp.Spec.TelemetryConfigRef are evaluated outside? If not, would you mind reducing this to func emitInlineTelemetryIgnoredEvent(vmcp *mcpv1beta1.VirtualMCPServer) and do al the math in it?
There was a problem hiding this comment.
Done in c25df52 — emitInlineTelemetryIgnoredEvent now takes only vmcp and computes usesIgnoredInline internally.
Signed-off-by: Ravi Tharuma <RaviTharuma@users.noreply.github.com>
Review asked emitInlineTelemetryIgnoredEvent to take only the VirtualMCPServer and evaluate Spec.Config.Telemetry and Spec.TelemetryConfigRef inside the helper. Co-authored-by: Ravi Tharuma <RaviTharuma@users.noreply.github.com>
fc67cfa to
c25df52
Compare
3 participants
Follow-up from #6276 after closing #6277. Operator ignores spec.config.telemetry and emits a one-shot Warning (InlineTelemetryIgnored) when it is set without telemetryConfigRef. Docs no longer claim inline still works for operator vMCP. /metrics stays unregistered without the ref (HTTP 406).