Report key-signed artifacts as such at install - #6471
Open
lorenzozanee wants to merge 1 commit into
Open
Conversation
A skill or plugin pushed with --key produces a validly key-signed artifact, but install verification is keyless-only. The artifact was therefore refusing with a generic signature failure and --allow-unsigned could not override it because the error was ErrSignatureInvalid rather than ErrUnsigned. Classify the layout via Bundle.HasCertificate and surface ErrKeySigned with an actionable message stating that key-pair signatures cannot be verified at install time, that --allow-unsigned does not apply, and that the artifact should be re-published with keyless signing. Add the same handling for catalog-constrained and sync/upgrade paths and document the limitation on thv skill push --key. Closes stacklok#6442 Signed-off-by: lorenzozanee <wyz0707@proton.me>
lorenzozanee
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
aponcedeleonch,
jhrozek,
rdimitrov,
reyortiz3 and
tgrunnagle
as code owners
August 31, 2026 03:06
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6471 +/- ##
=======================================
Coverage 78.02% 78.03%
=======================================
Files 767 767
Lines 74273 74298 +25
=======================================
+ Hits 57955 57975 +20
- Misses 16313 16318 +5
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A skill or plugin pushed with
thv skill push --keyproduces a validly key-signed artifact, but install-time verification is keyless-only. The install previously failed with a generic signature error that--allow-unsignedcould not override. This change classifies the key-signed layout distinctly and reports an actionable refusal.Fixes #6442
Type of change
Test plan
task test)task test-e2e)task lint-fix)API Compatibility
v1beta1API, OR theapi-break-allowedlabel is applied and the migration guidance is described above.